feat(files_sharing): configure public share link base URL by camr0 · Pull Request #62146 · nextcloud/server

camr0 · 2026-07-15T04:45:37Z

Related: Change domain URL in shared links #54904

Summary

Adds an optional 'shareapi_public_link_base_url' config flag to set a custom base URL just for share links. When unset, Nextcloud behaves exactly the same.

The new "PublicShareUrlGenerator" reads the config value and validates that it's a valid HTTP(S) URL. If it's unset or if the URL is invalid, we fall back to Nextcloud's existing URL generator. Existing references to the current URL generator are replaced with this new one for the OCS Share API URL field, public shares, and public link reminder emails.

At the same time, all URLs unrelated to sharing remain unchanged and still use the standard UrlGenerator.

The web UI is also updated to use the OCS response's URL field, instead of reconstructing the share link from the current base URL. Again, if the flag is unset, we fall back to the existing local construction.

TYPE_EMAIL shares now expose a URL field in the OCS response. Also, ShareByMailProvider now takes PublicShareUrlGenerator, both email paths use it (sendEmail() and sendNote()).

This is my first contribution to this project, so I'd appreciate any feedback or guidance on how to approach the documentation and other details.

Assisted-by: Codex:GPT-5.6

Before:

After:

Updated Documentation PR

TODO

Manual live testing
- when flag unset, link remains with default base URL
- when valid flag set, link works correctly with custom base URL
- when invalid flag set, link still remains with default base url (fallback)
Screenshots
Update documentation (occ config:app:set core shareapi_public_link_base_url --value='https://example.com/')

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

The content of this PR was partly or fully generated using AI

Documentation for nextcloud/server#62146 Signed-off-by: Ali Aslam <ali.aslam@zohomail.com> Signed-off-by: Ali Aslam <ali.aslam@zohomail.com>

camr0 · 2026-07-22T07:13:24Z

Documentation added in nextcloud/documentation#15361
nextcloud/documentation#15361

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9df62106ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Assisted-by: Codex:GPT-5 Signed-off-by: Ali Aslam <ali.aslam@zohomail.com>

Build the share link path through the router instead of hardcoding '/s/{token}' so instances without pretty URLs keep their '/index.php' front controller prefix when a custom base URL is configured. The instance webroot is still replaced by the configured base URL. Also trim surrounding whitespace from the configured value and log a warning (once per process) when a non-empty value is rejected, instead of falling back silently. Assisted-by: ClaudeCode:kimi-k3[1m] Signed-off-by: Ali Aslam <ali.aslam@zohomail.com>

The share notification and note emails still built the share link with the instance URL generator, so recipients received links pointing at the internal host even when shareapi_public_link_base_url was set. Generate them through PublicShareUrlGenerator like the other public share links. Assisted-by: ClaudeCode:kimi-k3[1m] Signed-off-by: Ali Aslam <ali.aslam@zohomail.com>

Assisted-by: ClaudeCode:kimi-k3[1m] Signed-off-by: Ali Aslam <ali.aslam@zohomail.com>

Wrap Server::get(ShareByMailProvider::class) in a try/catch so that if the provider's dependencies cannot be resolved (e.g. PublicShareUrlGenerator from files_sharing is not autoloaded when the app is disabled), the provider factory falls back to null instead of throwing, matching the pattern already used for registered share providers. Assisted-by: ClaudeCode:kimi-k3[1m] Signed-off-by: Ali Aslam <ali.aslam@zohomail.com>

github-actions · 2026-07-30T02:13:46Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

come-nc

I’m not entirely sold on the API design, but I’m not sure how I would’ve designed it either.
The fact that it sits in an application is also questionable, is it never needed for other application to get this public share URL?
It’s also ugly to have options in appconfig which are only meant to be set with occ, but it looks like there are precedent and this is not the only one under the core appid for sharing.

come-nc · 2026-08-03T13:39:11Z

 		private IGroupManager $groupManager,
 		private IUserManager $userManager,
 		private IRootFolder $rootFolder,
 		private IURLGenerator $urlGenerator,


The standard url generator is still used?

Same question for the other classes where the new generator is injected.

Yea the standard URL generator is still used for generating every link that’s not a share link. ShareAPIController, DefaultPublicShareTemplateProvider, and SharesReminderJob all still use it for internal URLs. Also, PublicShareUrlGenerator falls back on the standard URL generator when the custom base URL isn’t set.

come-nc · 2026-08-03T13:49:34Z

 		$ocs->cleanup();
 	}

+	#[\PHPUnit\Framework\Attributes\Group(name: 'RoutingWeirdness')]


Why is it in RoutingWeirdness?

I didn’t know exactly where to put it, RoutingWeirdness made sense since the result depends on the router config (checking if it contains /index.php). testCreateShareLink() uses the same group so I figured it made sense.

come-nc · 2026-08-03T13:53:26Z

+			try {
+				$this->shareByMailProvider = Server::get(ShareByMailProvider::class);
+			} catch (\Throwable $e) {
+				$this->logger->warning(
+					'Could not load sharebymail share provider: {message}',
+					['message' => $e->getMessage(), 'exception' => $e],
+				);
+				return null;
+			}


Why is this method called when files_sharing is disabled? Does that mean there is a behavior change with this?

Yea this is a good catch. I put a try/catch to disable sharebymail if we hit this edgecase, but that still creates an unnecessary dependency. In retrospect, putting the code inside of the files_sharing application might not have been the best move, since these are two independent applications and this PR makes sharebymail dependent on files_sharing. Should I move the shared URL generator to core? This is my first PR to the project, so I’m not sure of the exact right place to make this change. Any feedback would be appreciated. Thanks.

camr0 force-pushed the public-share-base-url branch from 838a43c to 9df6210 Compare July 22, 2026 05:53

camr0 mentioned this pull request Jul 22, 2026

docs(sharing): document shareapi_public_link_base_url app config nextcloud/documentation#15361

Open

4 tasks

camr0 marked this pull request as ready for review July 22, 2026 07:15

camr0 requested review from a team as code owners July 22, 2026 07:15

camr0 requested review from come-nc, kristian-zendato, leftybournes, nfebe and sorbaugh and removed request for a team July 22, 2026 07:15

chatgpt-codex-connector Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread apps/sharebymail/lib/ShareByMailProvider.php

camr0 added 8 commits July 22, 2026 02:51

feat(sharing): configure public share link base URL

8647de1

Assisted-by: Codex:GPT-5 Signed-off-by: Ali Aslam <ali.aslam@zohomail.com>

test(files_sharing): cover public share link copy URLs

aa26dcc

Assisted-by: Codex:GPT-5 Signed-off-by: Ali Aslam <ali.aslam@zohomail.com>

test(files_sharing): fix public share link test style

8792966

Assisted-by: Codex:GPT-5 Signed-off-by: Ali Aslam <ali.aslam@zohomail.com>

fix(files_sharing): generate file request share URLs

973d683

Assisted-by: Codex:GPT-5 Signed-off-by: Ali Aslam <ali.aslam@zohomail.com>

chore(files_sharing): compile assets

7860e5d

Assisted-by: ClaudeCode:kimi-k3[1m] Signed-off-by: Ali Aslam <ali.aslam@zohomail.com>

camr0 force-pushed the public-share-base-url branch from 9df6210 to eded848 Compare July 22, 2026 07:51

github-actions Bot added the feedback-requested label Jul 30, 2026

come-nc reviewed Aug 3, 2026

View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

feat(files_sharing): configure public share link base URL - #62146

feat(files_sharing): configure public share link base URL#62146
camr0 wants to merge 8 commits into
nextcloud:masterfrom
camr0:public-share-base-url

camr0 commented Jul 15, 2026 •

edited

Loading

Uh oh!

camr0 commented Jul 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 30, 2026

Uh oh!

come-nc left a comment

Uh oh!

come-nc Aug 3, 2026

Uh oh!

come-nc Aug 3, 2026

Uh oh!

camr0 Aug 6, 2026

Uh oh!

come-nc Aug 3, 2026

Uh oh!

camr0 Aug 6, 2026

Uh oh!

come-nc Aug 3, 2026

Uh oh!

camr0 Aug 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

camr0 commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

Checklist

AI (if applicable)

Uh oh!

camr0 commented Jul 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions Bot commented Jul 30, 2026

Uh oh!

come-nc left a comment

Choose a reason for hiding this comment

Uh oh!

come-nc Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

come-nc Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

camr0 Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

come-nc Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

camr0 Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

come-nc Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

camr0 Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camr0 commented Jul 15, 2026 •

edited

Loading