fix(appconfig): make type-conflict error self-explanatory - #63450
Open
ChristophWurst wants to merge 1 commit into
Open
fix(appconfig): make type-conflict error self-explanatory#63450ChristophWurst wants to merge 1 commit into
ChristophWurst wants to merge 1 commit into
Conversation
When a stored app config value has a different type than the one an app requests via a typed getter, getTypedValue() threw the opaque message 'conflict with value type from database' with no app, key or type information. Admins had no way to tell which key was affected or why. Name the config key and both types (using convertTypeToString(), like the setTypedValue() throw already does) in the log line and exception message. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
requested review from
Altahrim,
come-nc,
icewind1991 and
provokateurin
and removed request for
a team
August 21, 2026 09:27
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
CarlSchwan
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a stored app config value has a different type than the one an app requests via a typed getter, getTypedValue() threw the opaque message 'conflict with value type from database' with no app, key or type information. Admins had no way to tell which key was affected or why. Example: nextcloud/mail#13537.
Name the config key and both types (using convertTypeToString(), like the setTypedValue() throw already does) in the log line and exception message.
Before:
After:
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)