Skip to content

chore(ocp): mark events as Listenable instead of Consumable #66024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kesselb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(ocp): mark events as Listenable instead of Consumable #66024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/public/Collaboration/AutoComplete/AutoCompleteFilterEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace OCP\Collaboration\AutoComplete;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;
use OCP\EventDispatcher\Event;

/**
Expand All @@ -21,7 +21,7 @@
* @since 28.0.0
* @template T of array
*/
#[Consumable(since: '28.0.0')]
#[Listenable(since: '28.0.0')]
class AutoCompleteFilterEvent extends Event {
/**
* @since 28.0.0
Expand Down
4 changes: 2 additions & 2 deletions lib/public/Comments/CommentsEntityEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace OCP\Comments;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;
use OCP\EventDispatcher\Event;

/**
Expand All @@ -17,7 +17,7 @@
* @since 9.1.0
* @since 28.0.0 Dispatched as a typed event
*/
#[Consumable(since: '9.1.0')]
#[Listenable(since: '9.1.0')]
class CommentsEntityEvent extends Event {
/**
* @since 9.1.0
Expand Down
4 changes: 2 additions & 2 deletions lib/public/Comments/CommentsEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace OCP\Comments;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;
use OCP\EventDispatcher\Event;
use OCP\EventDispatcher\IWebhookCompatibleEvent;

Expand All @@ -19,7 +19,7 @@
*
* In the future, once the deprecated methods are removed, this class will be abstract.
*/
#[Consumable(since: '9.0.0')]
#[Listenable(since: '9.0.0')]
class CommentsEvent extends Event implements IWebhookCompatibleEvent {
/**
* @since 11.0.0
Expand Down
4 changes: 2 additions & 2 deletions lib/public/Comments/Events/BeforeCommentUpdatedEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace OCP\Comments\Events;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;
use OCP\Comments\CommentsEvent;
use OCP\Comments\IComment;

Expand All @@ -17,7 +17,7 @@
*
* @since 33.0.0
*/
#[Consumable(since: '33.0.0')]
#[Listenable(since: '33.0.0')]
final class BeforeCommentUpdatedEvent extends CommentsEvent {
/**
* CommentEvent constructor.
Expand Down
4 changes: 2 additions & 2 deletions lib/public/Comments/Events/CommentAddedEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace OCP\Comments\Events;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;
use OCP\Comments\CommentsEvent;
use OCP\Comments\IComment;

Expand All @@ -17,7 +17,7 @@
*
* @since 33.0.0
*/
#[Consumable(since: '33.0.0')]
#[Listenable(since: '33.0.0')]
final class CommentAddedEvent extends CommentsEvent {
/**
* CommentAddedEvent constructor.
Expand Down
4 changes: 2 additions & 2 deletions lib/public/Comments/Events/CommentDeletedEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace OCP\Comments\Events;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;
use OCP\Comments\CommentsEvent;
use OCP\Comments\IComment;

Expand All @@ -17,7 +17,7 @@
*
* @since 33.0.0
*/
#[Consumable(since: '33.0.0')]
#[Listenable(since: '33.0.0')]
final class CommentDeletedEvent extends CommentsEvent {
/**
* CommentRemovedEvent constructor.
Expand Down
4 changes: 2 additions & 2 deletions lib/public/Comments/Events/CommentUpdatedEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace OCP\Comments\Events;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;
use OCP\Comments\CommentsEvent;
use OCP\Comments\IComment;

Expand All @@ -17,7 +17,7 @@
*
* @since 33.0.0
*/
#[Consumable(since: '33.0.0')]
#[Listenable(since: '33.0.0')]
final class CommentUpdatedEvent extends CommentsEvent {
/**
* CommentUpdatedEvent constructor.
Expand Down
4 changes: 2 additions & 2 deletions lib/public/Files/ObjectStore/Events/BucketCreatedEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@

namespace OCP\Files\ObjectStore\Events;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;
use OCP\EventDispatcher\Event;

/**
* @since 33.0.0
*/
#[Consumable(since: '33.0.0')]
#[Listenable(since: '33.0.0')]
class BucketCreatedEvent extends Event {

/**
Expand Down
4 changes: 2 additions & 2 deletions lib/public/Interaction/RestrictInteractionEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace OCP\Interaction;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;
use OCP\EventDispatcher\Event;
use OCP\EventDispatcher\IEventDispatcher;
use OCP\IUser;
Expand All @@ -28,7 +28,7 @@
*
* @since 34.0.2
*/
#[Consumable(since: '34.0.2')]
#[Listenable(since: '34.0.2')]
final class RestrictInteractionEvent extends Event {
/**
* @since 34.0.2
Expand Down
4 changes: 2 additions & 2 deletions lib/public/Share/ShareReview/Events/ShareReviewAccessCheckEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace OCP\Share\ShareReview\Events;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;
use OCP\EventDispatcher\Event;

/**
Expand Down Expand Up @@ -67,7 +67,7 @@
*
* @since 34.0.2
*/
#[Consumable(since: '34.0.2')]
#[Listenable(since: '34.0.2')]
class ShareReviewAccessCheckEvent extends Event {

private bool $handled = false;
Expand Down
4 changes: 2 additions & 2 deletions lib/public/SystemTag/Events/AbstractTagEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace OCP\SystemTag\Events;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;
use OCP\EventDispatcher\Event;
use OCP\SystemTag\ISystemTag;

Expand All @@ -18,7 +18,7 @@
*
* @since 35.0.0
*/
#[Consumable(since: '35.0.0')]
#[Listenable(since: '35.0.0')]
abstract class AbstractTagEvent extends Event {
/**
* AbstractTagEvent constructor
Expand Down
4 changes: 2 additions & 2 deletions lib/public/SystemTag/Events/TagCreatedEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@

namespace OCP\SystemTag\Events;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;

/**
* Event triggered when creating a new tag.
*
* @since 35.0.0
*/
#[Consumable(since: '35.0.0')]
#[Listenable(since: '35.0.0')]
final class TagCreatedEvent extends AbstractTagEvent {
}
4 changes: 2 additions & 2 deletions lib/public/SystemTag/Events/TagDeletedEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@

namespace OCP\SystemTag\Events;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;

/**
* Event triggered when deleting a new tag.
*
* @since 35.0.0
*/
#[Consumable(since: '35.0.0')]
#[Listenable(since: '35.0.0')]
final class TagDeletedEvent extends AbstractTagEvent {
}
4 changes: 2 additions & 2 deletions lib/public/SystemTag/Events/TagUpdatedEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@

namespace OCP\SystemTag\Events;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;
use OCP\SystemTag\ISystemTag;

/**
* Event triggered when updated a tag.
*
* @since 35.0.0
*/
#[Consumable(since: '35.0.0')]
#[Listenable(since: '35.0.0')]
final class TagUpdatedEvent extends AbstractTagEvent {
/**
* TagUpdatedEvent constructor
Expand Down
2 changes: 0 additions & 2 deletions lib/public/User/Events/UserEnumerationFilterEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

namespace OCP\User\Events;

use OCP\AppFramework\Attribute\Consumable;
use OCP\AppFramework\Attribute\Listenable;
use OCP\EventDispatcher\Event;

Expand All @@ -21,7 +20,6 @@
*
* @since 31.0.14
*/
#[Consumable(since: '31.0.14')]
#[Listenable(since: '31.0.14')]
class UserEnumerationFilterEvent extends Event {
/** @var list<string> $initialUsers */
Expand Down
Loading