Skip to content

test(lint): Lint code base against PHP 8.6 - #66872

Open
nextcloud-command wants to merge 7 commits into
masterfrom
techdebt/8.6/welcome
Open

nextcloud-command wants to merge 7 commits into
masterfrom
techdebt/8.6/welcome

Conversation

@nextcloud-command

@nextcloud-command nextcloud-command commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Included fixes:

  • Had to bump guzzlehttp/promises to 2.6+ because it contains a class Is which is no longer allowed
  • internal session switched to strict mode by default which failed our tests. Also reproducable on 8.5 when strict mode is manually enabled there

nextcloud-command and others added 4 commits November 21, 2026 18:26
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
…HP 8.6

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Joas Schilling <coding@schilljs.com>
…h PHP 8.6

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Joas Schilling <coding@schilljs.com>
elgorro added a commit to elgorro/aiquila that referenced this pull request Nov 21, 2026
…ob (#1056)

Part of #1044 and #1037. It does not close #1044: raising `max-version`
waits for Nextcloud.

## Findings

- **Nextcloud does not support 8.6 yet.** `lib/versioncheck.php` on both
`stable35` and `master` (36.0.0 dev) refuses `PHP_VERSION_ID >= 80600`
("not compatible with PHP>=8.6"). Upstream has just started on 8.6 with
a lint job in nextcloud/server#66872. So `info.xml` keeps
`max-version="8.5"`, and `CLAUDE.md` and the install docs stay as they
are.
- **The 8.4 floor still holds.** Nextcloud 35 and 36 need 8.3 or later
(33 and 34 need 8.2). Our floor is deliberately higher, as
`docs/nextcloud-compatibility.md#php` already explains.
- **Psalm 6.20 cannot target 8.6.** `--php-version=8.6` reports "not
supported or doesn't exist". Analysis that targets 8.6 waits for Psalm 7
(#971).

## What changed

- **New job `Nextcloud App Tests (PHP 8.6, experimental)`** in
`test.yml`, with `continue-on-error: true` and steps gated on
`changes.nextcloud` like the others. It runs `composer test --
--display-deprecations --fail-on-deprecation` and `composer psalm` on
8.6. It is **not** a required check, and the required `Nextcloud App
Tests` (8.5) is unchanged, so the required-check name stays the same.
- **Docs**: the job is listed in `docs/dev/ci-cd.md`, and
`docs/nextcloud-compatibility.md` gets an 8.6 row ("Unsupported, tested
ahead").

## First 8.6 results (fixed in this PR)

- **`composer install` refused to run on 8.6**: `vimeo/psalm` 6.20.4
declares `php ~8.1.31 || … || ~8.5.0`. The job therefore installs with
`--ignore-platform-req=php+`, and the Psalm step runs even when the
tests fail. Noted on #971.
- **`imagedestroy()`**: 6 deprecations ("deprecated since 8.5, as it has
no effect since PHP 8.0") from `ImageOptimizer` and its tests. This
**already fires on 8.5**; the required job just doesn't fail on
deprecations. `lib/` now uses `unset()`, and the test calls are removed.
- After the fix, the 8.6 job passes: `OK (1805 tests, 5905 assertions)`
with no deprecations, and Psalm reports no errors on the 8.6 runtime.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants