Repository navigation
fix(core): correct admin updater status and warnings - #66913
Draft
joshtrichards wants to merge 4 commits into
Draft
joshtrichards wants to merge 4 commits into
joshtrichards wants to merge 4 commits into
Conversation
Add component tests for app lists, successful updates and the redirect countdown. Cover warnings, repair errors, failures and lost connections, including whether the updater continues monitoring or reports an unknown outcome. Assisted-by: Copilot:gpt-6.1-terra Signed-off-by: Josh <josh.t.richards@gmail.com>
Verify that repair warnings are sent to the updater as warning events with their translated message. Assisted-by: Copilot:gpt-6.1-terra Signed-off-by: Josh <josh.t.richards@gmail.com>
Preserve the severity of repair warnings so the updater can display them and avoid redirecting before administrators review them. Assisted-by: Copilot:gpt-6.1-terra Signed-off-by: Josh <josh.t.richards@gmail.com>
Previously, a repair error or lost connection could make the page report completion while the upgrade was still running. A server close without a done event could leave the page stuck in its running state. Keep monitoring until the server finishes or closes the stream, and report connection loss as an unknown outcome. Surface warnings and errors without automatically redirecting. Also show the app update list based on apps awaiting an upgrade, rather than the presence of incompatible apps. Assisted-by: Copilot:gpt-6.1-terra Signed-off-by: Josh <josh.t.richards@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while doing LLM-assisted code audits.
The updater could report completion after a repair error or lost connection even though the upgrade might still be running. It could also remain stuck after a server-side failure, redirect before an administrator saw repair warnings, or hide the list of apps awaiting an update.
This change keeps monitoring until the server finishes or closes the stream, reports lost connections as an unknown outcome, and surfaces warnings and errors without automatic redirection. It also corrects the app-list condition and adds tests for these cases (which failed until applying these fixes).
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)