Skip to content

fix(core): correct admin updater status and warnings - #66913

Draft
joshtrichards wants to merge 4 commits into
masterfrom
jtr/fixUpdaterAdminUI
Draft

joshtrichards wants to merge 4 commits into
masterfrom
jtr/fixUpdaterAdminUI

Conversation

@joshtrichards

@joshtrichards joshtrichards commented Nov 21, 2026 •

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

Found while doing LLM-assisted code audits.

The updater could report completion after a repair error or lost connection even though the upgrade might still be running. It could also remain stuck after a server-side failure, redirect before an administrator saw repair warnings, or hide the list of apps awaiting an update.

This change keeps monitoring until the server finishes or closes the stream, reports lost connections as an unknown outcome, and surfaces warnings and errors without automatic redirection. It also corrects the app-list condition and adds tests for these cases (which failed until applying these fixes).

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Add component tests for app lists, successful updates and the redirect countdown. Cover warnings, repair errors, failures and lost connections, including whether the updater continues monitoring or reports an unknown outcome.

Assisted-by: Copilot:gpt-6.1-terra

Signed-off-by: Josh <josh.t.richards@gmail.com>
Verify that repair warnings are sent to the updater as warning events with their translated message.

Assisted-by: Copilot:gpt-6.1-terra

Signed-off-by: Josh <josh.t.richards@gmail.com>
Preserve the severity of repair warnings so the updater can display
them and avoid redirecting before administrators review them.

Assisted-by: Copilot:gpt-6.1-terra

Signed-off-by: Josh <josh.t.richards@gmail.com>
Previously, a repair error or lost connection could make the page
report completion while the upgrade was still running. A server close
without a done event could leave the page stuck in its running state.

Keep monitoring until the server finishes or closes the stream, and
report connection loss as an unknown outcome. Surface warnings and errors without automatically redirecting.

Also show the app update list based on apps awaiting an upgrade,
rather than the presence of incompatible apps.

Assisted-by: Copilot:gpt-6.1-terra

Signed-off-by: Josh <josh.t.richards@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants