Skip to content

fix(files_sharing): treat read-only link shares with reshare as view only - #66916

Open
lazerg wants to merge 1 commit into
nextcloud:masterfrom
lazerg:fix/issue-66866-custom-permissions
Open

lazerg wants to merge 1 commit into
nextcloud:masterfrom
lazerg:fix/issue-66866-custom-permissions

Conversation

@lazerg

@lazerg lazerg commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Summary

A new public link share is created with READ | SHARE (17). Since #64202 hasCustomPermissions compares the raw permissions against the bundles, and read only (1) never includes SHARE, so 17 matched nothing and "Custom permissions" got checked.

SHARE is now ignored when comparing against the read only and file drop bundles. The sharing details tab also selects the matching radio instead of the raw value 17. ALL and ALL_FILE are still compared exactly, so the "removed from edit bundle" case from #64202 keeps working.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

…only

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: lazerg <lazerg2@gmail.com>
@lazerg
lazerg requested a review from a team as a code owner November 21, 2026 04:48
@lazerg
lazerg requested review from kristian-zendato, skjnldsv and susnux and removed request for a team November 21, 2026 04:48

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link share editor: "Custom permissions" is checked for a new link share

1 participant