Skip to content

Background jobs - #1084

Open
kesselb wants to merge 2 commits into
ui-polishfrom
background-jobs
Open

Background jobs#1084
kesselb wants to merge 2 commits into
ui-polishfrom
background-jobs

Conversation

@kesselb

@kesselb kesselb commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

This PR

  • Reworks the cron info, background jobs and slowest job (using IJobRuns to obtain failed and latest jobs, background job to collect the slowest jobs)
  • Adds background jobs pane
  • Tweaks the h3 style (so it's actually smaller than h2 and not bigger)

Screenshots

Background jobs pane

image image image

H3 tweak

B A
image image

@kesselb
kesselb requested a review from benjaminfrueh as a code owner August 9, 2026 13:55
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Aug 9, 2026
@kesselb kesselb self-assigned this Aug 9, 2026
@kesselb
kesselb requested a balanced review from Copilot August 9, 2026 14:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds background-job monitoring to the admin server information page.

Changes:

  • Adds recent, failed, and slowest-job collectors with periodic caching.
  • Adds cron health, job tables, and run-detail UI.
  • Introduces periodic polling, shared types, tests, and generated assets.

Reviewed changes

Copilot reviewed 33 out of 36 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/psalm-baseline.xml Updates collector suppressions.
tests/lib/SlowestJobsTest.php Removes superseded tests.
tests/lib/CronInfoTest.php Removes superseded tests.
tests/lib/Collector/CronTest.php Tests cron collection.
tests/lib/Collector/BackgroundJobsTest.php Tests job collection and aggregation.
src/views/SettingsAdmin.vue Integrates periodic job monitoring.
src/utils.ts Adds job formatting helpers.
src/types.ts Defines polling payload types.
src/main.css Styles headings and tables.
src/composables/useLiveData.ts Generalizes endpoint polling.
src/components/ThermalSection.vue Updates shared type import.
src/components/StatTile.vue Adds slots and severity styling.
src/components/SlowJobsTable.vue Displays aggregated jobs.
src/components/JobStatusIndicator.vue Displays run status.
src/components/JobRunsTable.vue Displays job runs.
src/components/JobRunDialog.vue Shows run details.
src/components/BackgroundJobsSection.vue Composes monitoring UI.
lib/StaticData.php Removes legacy cron data.
lib/SlowestJobs.php Removes legacy collector.
lib/Jobs/UpdateJobStats.php Schedules statistics refreshes.
lib/CronInfo.php Removes legacy cron service.
lib/Controller/PageController.php Adds periodic endpoint.
lib/Config/ConfigLexicon.php Defines statistics configuration.
lib/Commands/UpdateJobStats.php Adds manual refresh command.
lib/Collector/Cron.php Collects cron state.
lib/Collector/BackgroundJobs.php Collects and aggregates runs.
lib/AppInfo/Application.php Registers the config lexicon.
js/serverinfo-main.mjs.map.license Updates generated licenses.
js/serverinfo-main.mjs.license Updates generated licenses.
css/serverinfo-main.css Points to rebuilt stylesheet.
css/main-fEjI3iIv.chunk.css Adds rebuilt styles.
css/main-BzX8j22H.chunk.css Removes obsolete styles.
appinfo/routes.php Registers periodic route.
appinfo/info.xml Registers job and command.
Files not reviewed (1)
  • css/main-fEjI3iIv.chunk.css: Generated file

馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/components/BackgroundJobsSection.vue Outdated
Comment thread src/components/JobRunsTable.vue Outdated
Comment thread src/components/BackgroundJobsSection.vue Outdated
Comment thread src/components/StatTile.vue
@kesselb
kesselb requested a review from ChristophWurst August 9, 2026 14:30
@kesselb kesselb added this to the Nextcloud 35 milestone Aug 9, 2026
kesselb added 2 commits August 9, 2026 20:35
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted This PR contains AI-assisted commits enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants