feat(services): add log and login/session services - #982
Open
karlitschek wants to merge 4 commits into
Open
Conversation
ChristophWurst
added a commit
that referenced
this pull request
May 11, 2026
Injects LogTailReader, LoginStats, ActivityRate, and ActiveConnections — added in #982 — into AdminSettings and passes their data to the template params, making the services active instead of dead code. Extracted from #977. Co-Authored-By: Frank Karlitschek <karlitschek@users.noreply.github.com> AI-assisted: Claude Code (claude-sonnet-4-6) Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
split/05-services-logs-sessions
branch
from
May 11, 2026 16:19
7684654 to
b066758
Compare
Adds four read-only service classes used by the upcoming admin
dashboard cards. None are wired into existing controllers yet, so
this change is a pure addition with no behavior change.
* LogTailReader - last N WARN/ERROR entries from the JSON log
(no shell, line-bounded)
* LoginStats - bruteforce attempt counters and the top
offending IPs over recent windows
* ActivityRate - oc_activity row counts over the last hour /
day / week
* ActiveConnections - session counts derived from oc_authtoken
Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
ChristophWurst
added a commit
that referenced
this pull request
May 11, 2026
Injects LogTailReader, LoginStats, ActivityRate, and ActiveConnections — added in #982 — into AdminSettings and passes their data to the template params, making the services active instead of dead code. Extracted from #977. Co-Authored-By: Frank Karlitschek <karlitschek@users.noreply.github.com> AI-assisted: Claude Code (claude-sonnet-4-6) Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
split/05-services-logs-sessions
branch
from
May 11, 2026 16:25
b066758 to
b34e5c4
Compare
ChristophWurst
added a commit
that referenced
this pull request
May 11, 2026
Injects LogTailReader, LoginStats, ActivityRate, and ActiveConnections — added in #982 — into AdminSettings and passes their data to the template params, making the services active instead of dead code. Extracted from #977. Co-Authored-By: Frank Karlitschek <karlitschek@users.noreply.github.com> AI-assisted: Claude Code (claude-sonnet-4-6) Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
split/05-services-logs-sessions
branch
from
May 11, 2026 16:27
b34e5c4 to
8c232c6
Compare
ChristophWurst
added a commit
that referenced
this pull request
May 11, 2026
Injects LogTailReader, LoginStats, ActivityRate, and ActiveConnections — added in #982 — into AdminSettings and passes their data to the template params, making the services active instead of dead code. Extracted from #977. Co-Authored-By: Frank Karlitschek <karlitschek@users.noreply.github.com> AI-assisted: Claude Code (claude-sonnet-4-6) Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
split/05-services-logs-sessions
branch
from
May 11, 2026 16:37
8c232c6 to
9a7a730
Compare
ChristophWurst
added a commit
that referenced
this pull request
May 12, 2026
Injects LogTailReader, LoginStats, ActivityRate, and ActiveConnections — added in #982 — into AdminSettings and passes their data to the template params, making the services active instead of dead code. Extracted from #977. Co-Authored-By: Frank Karlitschek <karlitschek@users.noreply.github.com> AI-assisted: Claude Code (claude-sonnet-4-6) Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
split/05-services-logs-sessions
branch
from
May 12, 2026 13:42
9a7a730 to
28626fa
Compare
Member
|
Activity, auth token and rate limiting are conceptually problematic. This creates an inter app dependency where this app accesses the persistence of another app directly. The technically sound way would be to go through a public API. Looking into these right now … |
Member
|
Amended the original commit to fix the DCO and added class usage like it will be used later to avoid dead code. |
ChristophWurst
left a comment
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
👍 functionality-wise
Needs decision conceptually
kesselb
reviewed
May 12, 2026
kesselb
reviewed
May 12, 2026
kesselb
reviewed
May 12, 2026
ChristophWurst
added a commit
that referenced
this pull request
May 12, 2026
Injects LogTailReader, LoginStats, ActivityRate, and ActiveConnections — added in #982 — into AdminSettings and passes their data to the template params, making the services active instead of dead code. Extracted from #977. Co-Authored-By: Frank Karlitschek <karlitschek@users.noreply.github.com> AI-assisted: Claude Code (claude-sonnet-4-6) Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
split/05-services-logs-sessions
branch
from
May 12, 2026 17:55
28626fa to
7fbf7cc
Compare
Injects LogTailReader, LoginStats, ActivityRate, and ActiveConnections — added in #982 — into AdminSettings and passes their data to the template params, making the services active instead of dead code. Extracted from #977. Co-Authored-By: Frank Karlitschek <karlitschek@users.noreply.github.com> AI-assisted: Claude Code (claude-sonnet-4-6) Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
split/05-services-logs-sessions
branch
from
May 12, 2026 18:17
e7fafb7 to
b48f36c
Compare
karlitschek
requested review from
ChristophWurst and
kesselb
and
a lite review from Copilot
August 6, 2026 11:55
There was a problem hiding this comment.
Pull request overview
Adds four new read-only “metrics” services to support upcoming admin UI cards (log tail, brute force/login stats, activity rate, and active connections), along with tests, and wires them into the admin settings template parameters.
Changes:
- Added service classes:
LogTailReader,LoginStats,ActivityRate, andActiveConnections. - Integrated the new services into
AdminSettings::getForm()response parameters. - Added PHPUnit coverage for the new services and updated the Psalm baseline for DI/unused-method noise.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/psalm-baseline.xml | Suppresses Psalm “PossiblyUnusedMethod::__construct” for the newly added services. |
| tests/lib/LogTailReaderTest.php | Unit tests for log tail availability, filtering, limits, and truncation. |
| tests/lib/LoginStatsTest.php | DB tests for bruteforce attempt counts and top IP aggregation. |
| tests/lib/ActivityRateTest.php | DB tests for activity counts over time windows and top-actions shape. |
| tests/lib/ActiveConnectionsTest.php | DB tests for auth token–based active connection/session counts. |
| lib/Settings/AdminSettings.php | Injects the new services and adds their results to the admin settings template params. |
| lib/LogTailReader.php | Implements safe log tail reading from file-based JSON log entries. |
| lib/LoginStats.php | Implements bruteforce attempt counters and top offending IP queries. |
| lib/ActivityRate.php | Implements activity table counting over multiple time windows plus top-actions query. |
| lib/ActiveConnections.php | Implements auth token counting over time windows and by token type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+69
to
+73
| $qb->select('subjectparams', 'type') | ||
| ->selectAlias($qb->func()->count('activity_id'), 'count') | ||
| ->from('activity') | ||
| ->where($qb->expr()->gte('timestamp', $qb->createNamedParameter(time() - 86400))) | ||
| ->groupBy('type', 'subjectparams') |
Comment on lines
79
to
+83
| 'slowestJobs' => $this->slowestJobs->getSlowestJobs(), | ||
| 'logTail' => $this->logTailReader->recentErrors(), | ||
| 'loginStats' => $this->loginStats->getStats(), | ||
| 'activityRate' => $this->activityRate->getActivityRate(), | ||
| 'activeConnections' => $this->activeConnections->getActiveConnections(), |
Comment on lines
+73
to
+78
| private function countAttempts(?int $sinceTimestamp = null): int { | ||
| $qb = $this->db->getQueryBuilder(); | ||
| $qb->select($qb->func()->count('id'))->from('bruteforce_attempts'); | ||
| if ($sinceTimestamp !== null) { | ||
| $qb->where($qb->expr()->gte('occurred', $qb->createNamedParameter($sinceTimestamp))); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds four read-only service classes used by the upcoming admin dashboard cards. None are wired into existing controllers yet, so this change is a pure addition with no behavior change.
(no shell, line-bounded)
offending IPs over recent windows
day / week