Repository navigation
enh(Migration): add meta data information about DB changes - #3308
Merged
Merged
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
a team,
enjeck,
mejo- and
rubenvdlinde
and removed request for
a team
November 20, 2026 13:32
benjaminfrueh
approved these changes
Nov 20, 2026
samin-z
reviewed
Nov 20, 2026
| #[AddColumn(table: 'tables_contexts_page', name: 'description', type: ColumnType::TEXT)] | ||
| #[AddColumn(table: 'tables_contexts_page', name: 'version', type: ColumnType::INTEGER, description: 'optimistic locking counter, raised on every save')] | ||
| #[AddColumn(table: 'tables_contexts_page', name: 'slug', type: ColumnType::STRING, description: 'unique per application', notes: ['existing pages are filled in: start page "dashboard", others "page_<id>"'])] | ||
| #[AddIndex(table: 'tables_contexts_page', type: IndexType::UNIQUE, description: 'context_id + slug (tables_ctx_page_slug_uq)')] |
Contributor
There was a problem hiding this comment.
the widget table indexes created in 'haveWidgetTable()' are missing from the metadata.
#[AddIndex(table: 'tables_contexts_widget', type: IndexType::INDEX, description: 'page_id (tables_ctx_widget_page_idx)')]
#[AddIndex(table: 'tables_contexts_widget', type: IndexType::INDEX, description: 'node_rel_id (tables_ctx_widget_node_idx)')]
Member
Author
There was a problem hiding this comment.
They are being added upon creating, AddIndex is meant for manipulations of an existing table. As they start empty, there is no overhead of generating the index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick follow up to #3131
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)