Release all drivers (except nirfsg): nidcpower 1.6.0, others 1.5.0 - #2186
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2186 +/- ##
=======================================
Coverage 89.32% 89.32%
=======================================
Files 73 73
Lines 19048 19048
=======================================
+ Hits 17014 17015 +1
+ Misses 2034 2033 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
Version tested against should be updated first to latest drivers once published. That should be PR of it's own and should merge before these release changes. |
|
PR title is not detailed enough |
|
You'll probably need me to publish some of these releases to pypi. Let me know. |
vnktshr21
left a comment
There was a problem hiding this comment.
publish the PR once ready
|
@ni-jfitzger , we are upgrading the minor version for all drivers instead of patch version, which, some of the previous API releases followed for few drivers. Is this fine? For RFSG, it has been minor version bumps since the first release. |
I think the dropping of old Python Support merits a major version bump, though @marcoskirsch is free to disagree. I'm a little bit on the fence about it, honestly, because we restrict the Python version in setup.py, already to keep from breaking users. |
e113ef6 to
864a5aa
Compare
|
@ni-jfitzger @vnktshr21 . We've released RFSG 1.2.0 separately (hence its changes removed from this PR). For the rest of drivers upgraded major version to 2.0.0. |
Sorry, I'm having second thoughts about the major version bump. I shouldn't listen to Copilot for these things. |
@mshafer-NI We don't bump major to drop old Python versions, right? Python tooling ensures that users cannot install a package version that is incompatible with their current Python version. |
We normally bump minor for dropping old Python versions. There's an argument for that being a "breaking change" since users of the old Python can't use the newer version; however, most Python packages don't treat it that way. |
864a5aa to
d222073
Compare
|
Reverted back to minor version upgrades. @ni-jfitzger , Can you retrigger rhel run? |
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Releases all drivers in repo, bump up minor version.
See CHANGELOG.md for list of changes
List issues fixed by this Pull Request below, if any.
None
What testing has been done?
PR Validations