Skip to content

Updated auto_approve_merge with workflows:write - #48

Merged
pkthong merged 2 commits into
mainfrom
users/pkthong/autoapprove_workflows
Sep 28, 2026
Merged

pkthong merged 2 commits into
mainfrom
users/pkthong/autoapprove_workflows

Conversation

@pkthong

@pkthong pkthong commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

What does this Pull Request accomplish?

Updated auto_approve_merge yaml with correct permissions.

Why should this Pull Request be merged?

This will allow codeql and dependabot to approve its own workflow action updates.

What testing has been done?

None. This will be exercised when the first new dependabot action tries to update a workflow action.

@ni-github-admins

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Remove the unsupported permission before approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

Updates Dependabot auto-merge permissions to support workflow action updates.

Changes:

  • Adds workflows: write to the auto-merge job permissions.
File Summary
.github/​workflows/​auto_dependabot.yml The unsupported workflows: write permission makes the workflow invalid and should be removed.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/auto_dependabot.yml Outdated
Comment on lines +12 to +15
permissions:
pull-requests: write
contents: write
workflows: write

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. Corrected permissions.

@alexdubois-ni alexdubois-ni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkthong
pkthong merged commit e297e01 into main Sep 28, 2026
32 checks passed
@pkthong
pkthong deleted the users/pkthong/autoapprove_workflows branch September 28, 2026 22:01
@pkthong
pkthong removed the request for review from Copilot September 28, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants