Repository navigation
Consent: keep the account's agents apart (#25) - #32
Merged
Merged
Conversation
A WebID another listed WebID declares as its agent (acl:delegates, read from the public profile as N-Triples) moves under a closed "Your agents" disclosure. Only this server's profiles are read, bounded in count and time, without cookies; an unreadable profile moves nothing, and the person is never left with only agents in view. Smoke: links an agent WebID to the test account, adds the delegation to the served card, checks the agent is apart and closed; with the card unreadable, nothing moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25.
What changes (
overlay/templates/identity/oidc/consent.html.ejs,overlay/main.css)acl:delegatesgoes under a closed Your agents (n) disclosure, below the person's own. It is not removed.#agents,#agentList,#agentCount).Proposal points not done here
prov:SoftwareAgent): not needed for this. Left for later, if delegation alone proves too thin.Tests
test/smoke.mjs): linksprofile/agent#meto the test account (allowed without an ownership check, since the account made that pod) and adds the delegation triple to the served card via Playwright'sroute. The run has no Solid session to write the card for real. It then checks that the agent is listed apart, closed, with the card still in the main list. With the card fetch aborted, nothing moves. Screenshot06c-consent-agents.check-overrides.shis not affected (baseline unchanged).🤖 Generated with Claude Code