Repository navigation
Conversation
…ring GroupPosBased identified the matched route by the first non-empty capture group, so a group that matched the empty string was skipped. The request went to the next route's handler, or ended in a TypeError when there was none. Use PREG_UNMATCHED_AS_NULL and pick the first group that is not null. Fixes nikic#307
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GroupPosBased identified the matched route by the first non-empty capture group, so a group that matched the empty string was skipped. The request went to the next route's handler, or ended in a TypeError when there was none. Use PREG_UNMATCHED_AS_NULL and pick the first group that is not null.
Adds two regression cases to
DispatcherTestCase, so they run for all four strategies. They fail on master for GroupPosBased only; with this change the full suite passes.Fixes #307