Implement Phase 5 CLI tooling - #8
Open
bhavani-devi0806 wants to merge 1 commit into
Open
Conversation
manish-wekan
left a comment
manish-wekan
left a comment
Collaborator
There was a problem hiding this comment.
Please fix these issue, and report back
| return _DEP_RE.subn(_sub, text) | ||
|
|
||
|
|
||
| def _add_to_pyproject_dependencies(text: str, spec: str) -> str: |
Collaborator
There was a problem hiding this comment.
The dependencies = [...] regex is non-greedy, so "uvicorn[standard]>=0.20" truncates the captured span at the extras bracket. _add_to_pyproject_dependencies then splices that truncated span back, producing syntactically destroyed TOML. I reproduced the exact mangled output. Given this SDK itself depends on uvicorn, a user hitting this is likely, and there's no backup or rollback.
| PYPI_JSON = "https://pypi.org/pypi/nitrostack/json" | ||
| PYPI_VERSION_JSON = "https://pypi.org/pypi/nitrostack/{version}/json" | ||
|
|
||
| _DEP_RE = re.compile( |
Collaborator
There was a problem hiding this comment.
_DEP_RE matches nitrostack as a bare substring. nitrostack-studio==1.0.0 becomes nitrostack>=9.9.9-studio==1.0.0. This repo already ships a nitrostack-studio console script, so that naming pattern is live.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a new MCP app using the CLI and tested it in NitroStudio. The app connected successfully and the tools ran as expected, confirming the Phase 5 CLI changes did not break app creation or execution.