Compiler warnings

[e-perl-NOAA]

Note from full [tpl created yesterday (July 21, 2026) ] I made edits to:

Lose all of the compiler warnings

See issue #775 for initial post about these warnings.

[Rick-Methot-NOAA]

Thanks to @jimianelli for finding these code issues

• There are 50 instances that use sprintf that could be replaced by str. Most are in readcontrol. This is optional:

sprintf(onenum, "%d", F_std_multi);
to
onenum = str(F_std_multi);

• Then in readcontrol there are 4 instances where the placement of the ) is incorrect in lines that invoke density-dependence. For example,

change:  else if (abs(MGparm_1(j, 8) > 0)) //  density-dependence
to:          else if (abs(MGparm_1(j, 8)) > 0) //  density-dependence

These should be corrected and tested with a model that uses a density-dependent parameter.

• extra () here: else if( (Comp_Err_L(0, f)==3)) // MV Tweedie
• suggest adding this to prevent NAN: LinfR = posfun(LinfR, 1.0e-9, CrashPen);

[iantaylor-NOAA]

I believe that this issue was resolved by changes in the associated PRs: #781, #775, and maybe #779.