[feat] Update biomass/abundance/catch table - #373
Open
sbreitbart-NOAA wants to merge 11 commits into
Open
sbreitbart-NOAA wants to merge 11 commits into
sbreitbart-NOAA wants to merge 11 commits into
Conversation
… create_rda(); start "revamping" bnc table to match structure and formatting of landings tbl
…andings tbl; update documentation
sbreitbart-NOAA
force-pushed
the
revamp-tab-bnc
branch
from
September 24, 2026 18:07
a69c357 to
4f79947
Compare
| B.msy.max,,upper estimate of the biomass at maximum sustainable yield of the 95th percentile confidence interval,,,, | ||
| B.msy.min,,lower estimate of the biomass at maximum sustainable yield of the 95th percentile confidence interval,,,, | ||
| biomass_abundance_catch.abundance.units,, units of abundance measurement for biomass/abundance/catch table,,,, | ||
| biomass_abundance_catch.b.units,, units of biomass measurement for biomass/abundance/catch table,,,, |
Collaborator
There was a problem hiding this comment.
why is b an acronym but no other labels are?
| # imported from table_bnc | ||
| biomass_unit_label = "mt", | ||
| # imported from table_biomass_abundance_catch | ||
| bac_unit_label = c("biomass" = "mt", "abundance" = "fish", "catch" = "mt"), |
Collaborator
There was a problem hiding this comment.
I don't think this argument is in the roxygen documentation. Could you also change it to bnc?
Collaborator
There was a problem hiding this comment.
I feel like there has to be an automated way to update this function whenever we add a new figure_* or table_*
Schiano-NOAA
approved these changes
Sep 25, 2026
Schiano-NOAA
left a comment
Schiano-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
A couple of minor things, but otherwise looks good to me! Double check that one argument I mentioned has documentation.
Collaborator
|
I forgot to add -- on merge please set the message to include both info about the feature and the removal of the units from the function |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #358
Also removed "unit_label" argument from
create_rda()in all plotting functions as it was not used in the functions