FIX: with two concurrent audio streams in ui_audio first one cannot be stopped.#858
Open
anttiryt wants to merge 2 commits into
Open
FIX: with two concurrent audio streams in ui_audio first one cannot be stopped.#858anttiryt wants to merge 2 commits into
anttiryt wants to merge 2 commits into
Conversation
6 tasks
dceejay
requested changes
Jul 11, 2026
dceejay
left a comment
dceejay
left a comment
Member
There was a problem hiding this comment.
Hi @anttiryt - looks good. Rather than console.log we use node.log to log things in a slightly more formatted way - so please use that if you need to leave in those logging statements.
Also not sure if this is worth doing - but I guess you could also check for msg.reset being a number and only kill that instance if you wanted to enhance it further.
|
|
||
| events.on('ui-audio', function(msg) { | ||
| if (msg.reset) { | ||
| console.log("Audio Reset triggered. Current active stream count: " + audioSources.length); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the nasty bug where if you have background music playing and another sound effect on top like exclamation mark the background music could no longer be stopped.