Repository navigation
feat: remove multer limitations - #1225
UlisesGascon wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 29 29
Lines 2213 2213
=======================================
Hits 2127 2127
Misses 86 86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This is almost the same as PR #1096 from @bjohansebas with the exception of the maintainer list, which you updated separately in #1223 . multer@2.5.0 has shown some flaky behavior in GitHub Actions running under Ubuntu with Node.js 22, 24, 26 & 27 Alpha error: | 1) disk storage flush cleanup on aborted uploads
error: | should defer the abort unlink until the flush descriptor is closed:
error: |
error: | Uncaught AssertionError [ERR_ASSERTION]: _removeFile callback never fired (cleanup hung)
error: | + expected - actual
error: |
error: | -false
error: | +truere-running failed tests generally succeeded though. macOS & Windows were reliably successful in the same set of tests, so removing If you keep this PR instead of using #1096 then the commit message should be changed to from |
I think we are stable enough in Win and Macos at this moment, but let's see 👍