Skip to content

feat: remove multer limitations - #1225

Open
UlisesGascon wants to merge 1 commit into
mainfrom
multer/remove-restrictions
Open

UlisesGascon wants to merge 1 commit into
mainfrom
multer/remove-restrictions

Conversation

@UlisesGascon

Copy link
Copy Markdown
Member

I think we are stable enough in Win and Macos at this moment, but let's see 👍

@codecov-commenter

codecov-commenter commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.11%. Comparing base (98ba854) to head (91d0599).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1225   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2127     2127           
  Misses         86       86           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MikeMcC399

Copy link
Copy Markdown
Contributor

This is almost the same as PR #1096 from @bjohansebas with the exception of the maintainer list, which you updated separately in #1223 .

multer@2.5.0 has shown some flaky behavior in GitHub Actions running under Ubuntu with Node.js 22, 24, 26 & 27 Alpha

error:                     | 1) disk storage flush cleanup on aborted uploads
error:                     | should defer the abort unlink until the flush descriptor is closed:
error:                     |
error:                     | Uncaught AssertionError [ERR_ASSERTION]: _removeFile callback never fired (cleanup hung)
error:                     | + expected - actual
error:                     |
error:                     | -false
error:                     | +true

re-running failed tests generally succeeded though.

macOS & Windows were reliably successful in the same set of tests, so removing "skip": "win32" & removing "flaky": ["darwin"] looks fine.

If you keep this PR instead of using #1096 then the commit message should be changed to from feat: to lookup:.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants