Skip to content

build: add "[security]" to the PR title when appropriate #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nschonni wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: add "[security]" to the PR title when appropriate #2694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion build-automation.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ const nodeKeys = readFileSync(resolve(import.meta.dirname, 'keys', 'node.keys'))

const updatedVersions = [];

let isSecurity = true;

try {
console.log(
`Found major versions in versions.json: ${Object.keys(supportedVersions).join(', ')}`,
Expand Down Expand Up @@ -127,6 +129,7 @@ try {
} else if (latestVersion.version !== localVersion) {
console.log(`\t${variant}: updating to ${latestVersion.version}`);
updatedVersions.push(latestVersion.version);
isSecurity &= latestVersion.security;
writeFileSync(dockerfilePath, dockerfileOutput);
} else {
console.warn(
Expand All @@ -139,7 +142,7 @@ try {
// Let the GitHub Action library set the GITHUB_ENV file rather than manually handling it
exportVariable(
'NODE_PR_TITLE',
`feat: Node.js ${[...new Set(updatedVersions)].join(', ')}`,
`feat${isSecurity ? '[security]' : ''}: Node.js ${[...new Set(updatedVersions)].join(', ')}`,

@nschonni nschonni Nov 13, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`feat${isSecurity ? '[security]' : ''}: Node.js ${[...new Set(updatedVersions)].join(', ')}`,
`${isSecurity ? '[security]' : 'feat:'} Node.js ${[...new Set(updatedVersions)].join(', ')}`,

This would change it to [security] or feat: instead

@MikeMcC399 MikeMcC399 Nov 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm neutral to the addition of "feat:" here.

Although in the docker-node repo we've been using commit messages like this, the string also gets copied when creating the follow-on official PR for https://github.com/docker-library/official-images. They don't use fix: / feat: etc. on official-images.

);
} else {
console.log('No Pull Request will be created.');
Expand Down
Loading