feat: add HTTP_ALL_METHOD_COUNT for iterating method names - #880
Open
official-burak wants to merge 1 commit into
Open
feat: add HTTP_ALL_METHOD_COUNT for iterating method names#880official-burak wants to merge 1 commit into
official-burak wants to merge 1 commit into
Conversation
Embedders had to hardcode the method range, so QUERY never showed up in name caches. Unknown ids now return NULL instead of aborting. Fixes nodejs#872
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for writing this up. aiohttp had to hardcode the method range, so QUERY never showed up in the name cache.
This defines HTTP_ALL_METHOD_COUNT as one past the highest method id, generated from the same METHODS map as HTTP_ALL_METHOD_MAP. llhttp_method_name also returns NULL for an unknown id instead of aborting, so a 0..COUNT-1 loop stays safe if a gap appears later.
Fixes #872