Miscellaneous improvements to commonjs-extension-resolution-loader and pgp-loader#12
Merged
GeoffreyBooth merged 3 commits intoSep 29, 2022
Conversation
GeoffreyBooth
changed the title
GeoffreyBooth
marked this pull request as ready for review
September 25, 2022 17:01
arcanis
reviewed
Sep 26, 2022
aduh95
reviewed
Sep 27, 2022
GeoffreyBooth
force-pushed
the
commonjs-extension-resolution-loader-improvements
branch
from
September 27, 2022 18:50
33d3210 to
b89aab7
Compare
JakobJingleheimer
approved these changes
Sep 28, 2022
GeoffreyBooth
force-pushed
the
commonjs-extension-resolution-loader-improvements
branch
from
September 29, 2022 21:46
b89aab7 to
c23832a
Compare
Member
Author
|
I’m removing all version bumps from this PR so we can discuss those separately. I’m leaning towards never changing the versions in the |
GeoffreyBooth
deleted the
commonjs-extension-resolution-loader-improvements
branch
September 29, 2022 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to get the build passing:
shortCircuit: trueto PGP Loader (needed because we’re building in Node 18 now)Miscellaneous fixes:
isBuiltinper Fix commonjs-extension-resolution-loader #10 (comment)