fix: fall back gracefully when build symlink creation fails#3339
Open
PickBas wants to merge 1 commit into
Open
fix: fall back gracefully when build symlink creation fails#3339PickBas wants to merge 1 commit into
PickBas wants to merge 1 commit into
Conversation
Fixes: nodejs#3317 Signed-off-by: Kirill Saied <sayed.kirill@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change
On filesystems without symlink support (e.g. FAT),
node-gyp buildaborts withEPERM: ... symlinkwhen creatingbuild/node_gyp_bins/python3. This wraps the symlink creation in a try/catch: on a filesystem-limitation error it warns and continues without the symlink; any other error still propagates.PATHis only modified after the symlink succeeds, so a failed attempt leaves no half-state behind.Fixes: #3317