Skip to content

crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs - #63411

Open
panva wants to merge 4 commits into
nodejs:mainfrom
panva:crypto-add-siv-modes
Open

crypto: enable SIV and GCM-SIV modes in Cipher/Decipher APIs#63411
panva wants to merge 4 commits into
nodejs:mainfrom
panva:crypto-add-siv-modes

Conversation

@panva

@panva panva commented May 18, 2026

Copy link
Copy Markdown
Member

Closes #63393

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 18, 2026
@panva
panva force-pushed the crypto-add-siv-modes branch from a1ea9b7 to 127a852 Compare May 18, 2026 13:24
@panva
panva requested a review from tniessen May 18, 2026 13:24
@panva panva added the crypto Issues and PRs related to the crypto subsystem. label May 18, 2026
@panva
panva marked this pull request as ready for review May 18, 2026 13:24
@panva panva added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x labels May 18, 2026
@panva
panva force-pushed the crypto-add-siv-modes branch from 687e02b to b5764bc Compare May 18, 2026 13:45
@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.09677% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (fd5b135) to head (1ef6bd0).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_cipher.cc 87.09% 2 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63411      +/-   ##
==========================================
- Coverage   90.12%   90.11%   -0.01%     
==========================================
  Files         752      752              
  Lines      252325   252371      +46     
  Branches    47456    47472      +16     
==========================================
+ Hits       227407   227436      +29     
- Misses      16217    16233      +16     
- Partials     8701     8702       +1     
Files with missing lines Coverage Δ
src/crypto/crypto_cipher.h 68.47% <ø> (ø)
src/crypto/crypto_cipher.cc 78.04% <87.09%> (+1.34%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added review wanted PRs that need reviews. semver-minor PRs that contain new features and should be released in the next minor version. and removed dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels May 25, 2026
@panva
panva requested review from ChALkeR and jasnell June 7, 2026 09:57
@panva
panva marked this pull request as draft June 11, 2026 09:09
@panva
panva marked this pull request as ready for review June 14, 2026 10:13
@panva
panva force-pushed the crypto-add-siv-modes branch from 944bf43 to 7c39722 Compare June 29, 2026 08:14
Comment thread deps/ncrypto/ncrypto.h Outdated
Comment thread deps/ncrypto/ncrypto.cc Outdated
@panva
panva requested a review from tniessen June 30, 2026 21:04
@hylmarj

hylmarj commented Aug 17, 2026

Copy link
Copy Markdown

Do you have any idea when this feature will be released, and if so, in which version?

@panva
panva force-pushed the crypto-add-siv-modes branch from 823805b to 71999e4 Compare August 20, 2026 09:20
@panva panva removed the review wanted PRs that need reviews. label Aug 20, 2026
@panva panva added the review wanted PRs that need reviews. label Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. review wanted PRs that need reviews. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crypto: support AES-*-SIV and AES-*-GCM-SIV in createCipheriv()

6 participants