Skip to content

inspector: fix crash when writing to closed inspector socket #64209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yayapapa wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

inspector: fix crash when writing to closed inspector socket #64209

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fce2dc8
inspector: fix crash when writing to closed inspector socket
Yayapapa Jun 30, 2026
2a1112e
Update src/inspector_socket.cc
Yayapapa Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/inspector_socket.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,10 +401,12 @@ class WsHandler : public ProtocolHandler {
if (processed > 0) {
remove_from_beginning(data, processed);
}
} while (processed > 0 && !data->empty());
} while (processed > 0 && !data->empty() && tcp_);
}

void Write(const std::vector<char> data) override {
void Write(const std::vector<char>& data) override {
if (!tcp_)
return;
std::vector<char> output = encode_frame_hybi17(data);
WriteRaw(output, WriteRequest::Cleanup);
}
Expand Down Expand Up @@ -666,6 +668,8 @@ ProtocolHandler::ProtocolHandler(InspectorSocket* inspector,

int ProtocolHandler::WriteRaw(const std::vector<char>& buffer,
uv_write_cb write_cb) {
if (!tcp_)
return -1;
return tcp_->WriteRaw(buffer, write_cb);
}

Expand Down