Skip to content

test: use heapdump test for SecureContext memory tracking - #64344

Open
mertcanaltin wants to merge 3 commits into
nodejs:mainfrom
mertcanaltin:fix/remove-cctest-memory-tracking
Open

test: use heapdump test for SecureContext memory tracking#64344
mertcanaltin wants to merge 3 commits into
nodejs:mainfrom
mertcanaltin:fix/remove-cctest-memory-tracking

Conversation

@mertcanaltin

Copy link
Copy Markdown
Member

Replace cctest with a heap snapshot test for SecureContext memory tracking.

Refs: #59051

@joyeecheung #59051 (comment)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 7, 2026
@mertcanaltin

Copy link
Copy Markdown
Member Author

hey @joyeecheung I applied your last sugesstions (#62689 (comment), #62689 (comment))

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (fd5b135) to head (342ac8e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64344   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files         752      752           
  Lines      252325   252325           
  Branches    47456    47448    -8     
=======================================
+ Hits       227407   227416    +9     
- Misses      16217    16222    +5     
+ Partials     8701     8687   -14     

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
@mertcanaltin
mertcanaltin force-pushed the fix/remove-cctest-memory-tracking branch from b76e1c1 to 342ac8e Compare August 20, 2026 10:24
@MikeMcC399 MikeMcC399 added the review wanted PRs that need reviews. label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. review wanted PRs that need reviews. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants