fs,path: key glob matcher cache by platform#64571
Open
Archkon wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64571 +/- ##
=======================================
Coverage 90.15% 90.15%
=======================================
Files 744 744
Lines 242517 242518 +1
Branches 45688 45688
=======================================
+ Hits 218642 218650 +8
- Misses 15358 15361 +3
+ Partials 8517 8507 -10
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Jul 19, 2026
Contributor
Author
|
@lpinca Sorry to ping you and could you apply request ci for this pr? Thanks! |
Collaborator
Contributor
Author
|
@lpinca I don't know what is wrong with jenkins ci tests so could you take a look at these failed test ?Should I resolve these problems ? |
Contributor
Author
|
@Renegade334 @avivkeller Could you take a look at these failed tests ? |
avivkeller
approved these changes
Jul 26, 2026
Member
@Archkon please rebase, looks like CI needs you to |
MoLow
approved these changes
Jul 26, 2026
Glob matchers capture the path platform when they are created. Include the platform in the cache key so path.posix and path.win32 do not share incompatible matchers for the same pattern. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Contributor
Author
|
@avivkeller Done,and Maybe you need to apply request-ci again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64570