Skip to content

build: add host toolset to perfetto_sdk#64751

Open
islandryu wants to merge 1 commit into
nodejs:mainfrom
islandryu:build-perfetto-host-toolset
Open

build: add host toolset to perfetto_sdk#64751
islandryu wants to merge 1 commit into
nodejs:mainfrom
islandryu:build-perfetto-host-toolset

Conversation

@islandryu

Copy link
Copy Markdown
Member

./configure -C --with-perfetto fails GYP because v8_init#host (mksnapshot) needs perfetto_sdk#host, but perfetto_sdk never declared the host toolset.

Add 'toolsets': ['host', 'target'], matching temporal_capi and libuv.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jul 26, 2026
Signed-off-by: islandryu <shimaryuhei@gmail.com>
@islandryu
islandryu force-pushed the build-perfetto-host-toolset branch from 399790c to ad4369b Compare July 26, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants