Skip to content

crypto: honor NSS distrust-after dates#64753

Draft
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:cert
Draft

crypto: honor NSS distrust-after dates#64753
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:cert

Conversation

@Archkon

@Archkon Archkon commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Fixes: #64752

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@Archkon
Archkon marked this pull request as draft July 26, 2026 05:51
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 26, 2026
@Archkon Archkon changed the title stage crypto: honor NSS distrust-after dates Jul 26, 2026
@Archkon

Archkon commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

ping @bnoordhuis

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.09302% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (2c4ea73) to head (4b43155).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_context.cc 71.42% 3 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64753      +/-   ##
==========================================
- Coverage   90.15%   90.14%   -0.01%     
==========================================
  Files         743      743              
  Lines      242413   242458      +45     
  Branches    45657    45670      +13     
==========================================
+ Hits       218537   218570      +33     
- Misses      15362    15389      +27     
+ Partials     8514     8499      -15     
Files with missing lines Coverage Δ
src/crypto/crypto_context.h 100.00% <ø> (ø)
src/crypto/crypto_tls.cc 78.32% <100.00%> (+0.01%) ⬆️
src/crypto/crypto_context.cc 72.32% <71.42%> (+0.04%) ⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crypto: mk-ca-bundle.pl drops Izenpe.com and loses NSS SERVER_DISTRUST_AFTER semantics

2 participants