net: throw on multiple listen calls - #64871
Open
mcollina wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
mcollina
requested review from
Ethan-Arrowood and
guybedford
and removed request for
guybedford
July 31, 2026 11:58
Ethan-Arrowood
approved these changes
Jul 31, 2026
pimterry
approved these changes
Jul 31, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64871 +/- ##
==========================================
- Coverage 90.15% 90.12% -0.03%
==========================================
Files 746 751 +5
Lines 242764 252548 +9784
Branches 45741 47526 +1785
==========================================
+ Hits 218857 227615 +8758
- Misses 15418 16244 +826
- Partials 8489 8689 +200
🚀 New features to boost your workflow:
|
bjohansebas
approved these changes
Aug 1, 2026
efekrskl
approved these changes
Aug 21, 2026
efekrskl
left a comment
Member
There was a problem hiding this comment.
Could you add the missing Signed-off-by to the first commit?
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
fix-net-multiple-listen
branch
from
August 23, 2026 01:06
b04599c to
0c46676
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53204
Server.listen()could accept a second listen call while the first listen was still pending, allowing the later request to replace the earlier one. Track pending listen state and throwERR_SERVER_ALREADY_LISTENconsistently.The state is cleared on close, listen errors, handle transfer, and pipe permission failures.