tools: make env variables consistent in cron jobs - #65168
Merged
Conversation
Collaborator
|
Review requested:
|
aduh95
force-pushed
the
consistent-cron-envs
branch
5 times, most recently
from
August 10, 2026 13:41
6ef5a74 to
3fcf56f
Compare
Member
|
There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment. |
Contributor
Author
I'm not touching the permissions though |
Member
But there is a user change in |
panva
reviewed
Aug 10, 2026
panva
reviewed
Aug 10, 2026
Member
|
Is use of |
aduh95
force-pushed
the
consistent-cron-envs
branch
from
August 11, 2026 13:47
3a4eccd to
e775846
Compare
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Filip Skokan <panva.ip@gmail.com>
aduh95
force-pushed
the
consistent-cron-envs
branch
from
August 12, 2026 16:02
e775846 to
efed148
Compare
panva
approved these changes
Aug 20, 2026
aduh95
commented
Aug 20, 2026
aduh95
commented
Aug 20, 2026
panva
approved these changes
Aug 20, 2026
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/65168 β Done loading data for nodejs/node/pull/65168 ----------------------------------- PR info ------------------------------------ Title tools: make env variables consistent in cron jobs (#65168) β Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:consistent-cron-envs -> nodejs:main Labels meta, tools, author ready, commit-queue Commits 6 - tools: make env variables consistent in cron jobs - fixup! tools: make env variables consistent in cron jobs - squash! use same permissions as CQ - squash! Apply suggestion from @panva - squash! not early stage anymore - squash! not early stages anymore Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> -------------------------------------------------------------------------------- βΉ This PR was created on Sun, 09 Aug 2026 18:21:21 GMT β Approvals: 1 β - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65168#pullrequestreview-4983148316 β Last GitHub CI successful βΉ Green GitHub CI is sufficient -------------------------------------------------------------------------------- β No git cherry-pick in progress β No git am in progress β No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD β origin/main is now up-to-date - Downloading patch for 65168 From https://github.com/nodejs/node * branch refs/pull/65168/merge -> FETCH_HEAD β Fetched commits as 58d58a47e3f8..1316c0d3ee44 -------------------------------------------------------------------------------- [main 6b25dfdc6b] tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Sun Aug 9 20:13:26 2026 +0200 4 files changed, 26 insertions(+), 37 deletions(-) [main 977da716bc] fixup! tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:32 2026 +0200 3 files changed, 9 insertions(+), 157 deletions(-) [main 76d31e5981] squash! use same permissions as CQ Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 21:18:11 2026 +0200 1 file changed, 2 insertions(+) [main d766fff13e] squash! Apply suggestion from @panva Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:58 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main 162af24468] squash! not early stage anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:14 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main a0b2e90ff1] squash! not early stages anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:49 2026 +0200 1 file changed, 2 deletions(-) β Patches applied Please run the following commands to complete landinghttps://github.com/nodejs/node/actions/runs/32387611571 |
Collaborator
|
Landed in 12eb296 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-R/--repoexplicitly instead of an implicit use ofGH_REPOor let the tool figure out based on the local repoGH_TOKEN, since that's whatghchecks first according to https://cli.github.com/manual/gh_help_environmentgithub.tokenoversecrets.GITHUB_TOKENto help avoid confusing it withsecrets.GH_USER_TOKEN=auto-start-ci.yml, remove references tosecrets.GH_USER_TOKEN(add permissions meeting the ones we use for CQ filtering PRs)ownerandrepositoryas argv forcommit-queue.sh, it already expects to find e.g.GITHUB_SERVER_URLin the env, it's simpler for it to also expectGITHUB_REPOSITORYto be defined.git configcall to the workflow so a human running the script locally doesn't accidentally impersonate the bot.