test: convert test-async-local-storage forEach to for..of loop - #65270
Open
freida-code wants to merge 1 commit into
Open
test: convert test-async-local-storage forEach to for..of loop#65270freida-code wants to merge 1 commit into
freida-code wants to merge 1 commit into
Conversation
nodejs-github-bot
added
needs-ci
Author
|
@jasnell Tagging you for review! I look forward to future contributions! Thank you! |
jasnell
added
the
code-and-learn
jasnell
approved these changes
Aug 13, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
freida-code
changed the title
mertcanaltin
approved these changes
Aug 13, 2026
Collaborator
jasnell
added
the
author ready
Member
|
Thank you for the contribution and for participating in the code-and-learn! This has passed CI and is ready to land. If we get a second sign off, then it can land after 48 hours have passed, otherwise it will take a bit longer. |
avivkeller
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update async-local-storage-bind test to use
for..offor loop instead of.forEach()to avoid allocating a callback per iteration and have a cleaner stack.Completed during the Node JS workshop at RenderATL