src: fixup manual new/delete usages - #65348
Open
jasnell wants to merge 3 commits into
Open
Conversation
Collaborator
|
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
ronag
approved these changes
Aug 17, 2026
Member
|
Needs format fix CLANG_FORMAT_START=$(git merge-base HEAD main) make format-cppAnd lint fix too |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #65348 +/- ##
==========================================
+ Coverage 90.11% 90.12% +0.01%
==========================================
Files 752 752
Lines 252208 252170 -38
Branches 47447 47426 -21
==========================================
- Hits 227274 227273 -1
+ Misses 16219 16206 -13
+ Partials 8715 8691 -24
🚀 New features to boost your workflow:
|
jasnell
force-pushed
the
jasnell/unique-ptr-improvements
branch
from
August 17, 2026 13:23
aba9c37 to
101f99e
Compare
Collaborator
daeyeon
approved these changes
Aug 20, 2026
Signed-off-by: James M Snell <jasnell@gmail.com>
Use std::unique_ptr more consistently Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus
jasnell
force-pushed
the
jasnell/unique-ptr-improvements
branch
from
August 20, 2026 03:09
101f99e to
94e0827
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace a range of raw ptr new/delete usages to use std::unique_ptr in various places.