Skip to content

[v22.x] deps: V8: cherry-pick a6eaf7574109 - #65402

Open
juanarbol wants to merge 1 commit into
nodejs:v22.x-stagingfrom
juanarbol:ja/backport-v8
Open

[v22.x] deps: V8: cherry-pick a6eaf7574109#65402
juanarbol wants to merge 1 commit into
nodejs:v22.x-stagingfrom
juanarbol:ja/backport-v8

Conversation

@juanarbol

Copy link
Copy Markdown
Member

Original commit message:

[logging] Use RecursiveMutex for Logger

Logger::allows_code_compaction might be called from within a
CodeCreateEvent where initializing line script line ends might trigger
a GC. During compaction we check if code compaction is allowed which
calls back into the above Logger method.

Bug: 41497149
Change-Id: Ifd1b740df8600584780341d8214e995832e663b4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5572952
Reviewed-by: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#94140}

Refs: v8/v8@a6eaf75
Fixes: #65140

@juanarbol juanarbol added the lts-watch-v22.x PRs that may need to be released in v22.x label Aug 19, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Aug 19, 2026
@juanarbol
juanarbol requested a review from a team as a code owner August 20, 2026 19:41
@juanarbol juanarbol added request-ci Add this label to start a Jenkins CI on a PR. and removed build Issues and PRs related to build files or the CI. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Original commit message:

    [logging] Use RecursiveMutex for Logger

    Logger::allows_code_compaction might be called from within a
    CodeCreateEvent where initializing line script line ends might trigger
    a GC. During compaction we check if code compaction is allowed which
    calls back into the above Logger method.

    Bug: 41497149
    Change-Id: Ifd1b740df8600584780341d8214e995832e663b4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5572952
    Reviewed-by: Victor Gomes <victorgomes@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#94140}

Refs: v8/v8@a6eaf75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lts-watch-v22.x PRs that may need to be released in v22.x needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants