test: add validation for listener removal in read streams - #65421
Open
Paraspandey-debugs wants to merge 1 commit into
Open
test: add validation for listener removal in read streams#65421Paraspandey-debugs wants to merge 1 commit into
Paraspandey-debugs wants to merge 1 commit into
Conversation
nodejs-github-bot
added
needs-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a regression test covering the listener leak reported in #64214,
where repeated fileHandle.createReadStream({ autoClose: false, ... })
calls each attach a 'close' listener to the FileHandle that is never
removed once the stream ends. Over many ranged reads on a long-lived
handle this triggers MaxListenersExceededWarning and leaks memory.
The test creates 100 short-lived ranged read streams from a single
FileHandle and asserts that the FileHandle's 'close' listener count
returns to its pre-loop baseline after each stream is fully consumed.
A previous fix (#64227) was merged and then reverted (#65387) after
introducing a separate issue where a stream's reference on the
FileHandle could be released more than once. This PR adds test
coverage for the originally reported listener leak only.
Refs: #64214
Refs: #64227
Refs: #65387