Skip to content

crypto: remove obsolete BoringSSL shims and use available APIs - #65423

Open
panva wants to merge 3 commits into
nodejs:mainfrom
panva:boringssl-cleanup
Open

crypto: remove obsolete BoringSSL shims and use available APIs#65423
panva wants to merge 3 commits into
nodejs:mainfrom
panva:boringssl-cleanup

Conversation

@panva

@panva panva commented Aug 20, 2026

Copy link
Copy Markdown
Member

Use BoringSSL's current RSA and DH validation results instead of maintaining backend-specific prechecks and collapsing key errors.

Report negotiated TLS groups and the documented zero security level through BoringSSL's compatibility APIs.

BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides compatible secure heap status stubs. Use the common code paths.

Remove ClientHello helpers left unused since #64827 and require the fixed ML-KEM private-key import error.

panva added 2 commits August 20, 2026 12:27
BoringSSL implements OPENSSL_zalloc and BN_secure_new and provides
compatible secure heap status stubs. Use the common code paths.

Remove ClientHello helpers left unused by the early callback migration
and require the fixed ML-KEM private-key import error.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Use BoringSSL's current RSA and DH validation results instead of
maintaining backend-specific prechecks and collapsing key errors.

Report negotiated TLS groups and the documented zero security level
through BoringSSL's compatibility APIs.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@panva panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Aug 20, 2026
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 20, 2026
@panva panva added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Aug 20, 2026
@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 20, 2026
Comment thread deps/ncrypto/ncrypto.h
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants