permission: block FileHandle fsync and fdatasync - #65431
Open
RafaelGSS wants to merge 1 commit into
Open
Conversation
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65431 +/- ##
==========================================
- Coverage 90.14% 90.12% -0.03%
==========================================
Files 746 752 +6
Lines 242764 252327 +9563
Branches 45739 47469 +1730
==========================================
+ Hits 218848 227399 +8551
- Misses 15426 16221 +795
- Partials 8490 8707 +217
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Aug 20, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the Permission Model enabled, the top-level
fs.fsync()andfs.fdatasync()APIs are disabled because operations on already-open file descriptors cannot be tied to path grants, but the equivalentFileHandlemethods remained available. DisableFileHandle.sync()andFileHandle.datasync()for consistency and document the behavior.