permission: enforce addon permission in GetLinkedBinding - #65432
Open
RafaelGSS wants to merge 1 commit into
Open
permission: enforce addon permission in GetLinkedBinding#65432RafaelGSS wants to merge 1 commit into
RafaelGSS wants to merge 1 commit into
Conversation
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Collaborator
|
Review requested:
|
legendecas
approved these changes
Aug 20, 2026
BethGriggs
approved these changes
Aug 20, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65432 +/- ##
==========================================
- Coverage 90.14% 90.12% -0.03%
==========================================
Files 746 752 +6
Lines 242764 252322 +9558
Branches 45739 47449 +1710
==========================================
+ Hits 218848 227407 +8559
- Misses 15426 16217 +791
- Partials 8490 8698 +208
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process._linkedBinding()did not enforce the Addon permission check used byprocess.dlopen(). Apply the same permission check before resolving a linked binding, including afterprocess.permission.drop('addon').