perf_hooks: add binary export/import to Histogram - #65434
Open
jasnell wants to merge 4 commits into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
force-pushed
the
jasnell/more-histogram-fun-2
branch
from
August 20, 2026 15:51
00936d8 to
fbcb489
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65434 +/- ##
==========================================
+ Coverage 90.11% 90.13% +0.01%
==========================================
Files 752 752
Lines 252208 253239 +1031
Branches 47447 47627 +180
==========================================
+ Hits 227274 228245 +971
- Misses 16219 16230 +11
- Partials 8715 8764 +49
🚀 New features to boost your workflow:
|
jasnell
force-pushed
the
jasnell/more-histogram-fun-2
branch
from
August 20, 2026 19:20
fbcb489 to
5d9f7ce
Compare
Welch's t-test, Mann-Whitney U test, Cohen's d, and Cliff's delta, and and handful of others These methods enable in-process benchmark comparison and regression detection without external dependencies. No new dependencies. Tests and docs created by the AI agent. Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus
Add an --analyze flag that performs statistical analysis directly
after benchmarks complete, eliminating the need for R and compare.R.
When --analyze is specified, compare.js collects the rate data during
the run and prints a statistical summary table instead of CSV output.
The table matches the format of compare.R: improvement percentage,
significance stars (* p<0.05, ** p<0.01, *** p<0.001), and confidence
intervals at three risk levels.
Also adds a --max-regression N option that causes the compare.js to
exit with 1 (error) when the `--new` is N% slower. Useful for CI
use to detect regressions.
Uses the histogram API's welchTest() and cohensD() methods introduced
in the previous commit. Benchmark rates are scaled to integers for
HdrHistogram recording; the --scale option (default 1000) controls
the multiplier for precision.
Usage:
node benchmark/compare.js --old ./node-old --new ./node-new \
--analyze url
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
jasnell
force-pushed
the
jasnell/more-histogram-fun-2
branch
from
August 20, 2026 20:36
5d9f7ce to
dfaacaf
Compare
jasnell
added
notable-change
Contributor
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Member
Author
|
Notes for the notable change: This PR gives Histogram a new binary interchange format |
jasnell
added
the
commit-queue-rebase
legendecas
approved these changes
Aug 20, 2026
| } | ||
|
|
||
| // ----------------------------------------------------------------------- | ||
| // Minimal CBOR encoder/decoder (RFC 8949) -- just enough types for |
Member
There was a problem hiding this comment.
Maybe we should get deps/inspector_protocol/crdtp/cbor.h into core...
Provide a binary export/import mechanism for histograms. Since there is no standard interchange format for histograms, using CBOR is meant to make the format as platform/runtime agnostic as possible while producing a compact/efficient result. No new dependency is introduced, we just encode the CBOR directly. Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
jasnell/more-histogram-fun-2
branch
from
August 20, 2026 22:54
dfaacaf to
28eb138
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on: #65416
Pay attention only to the last two commits.