fs: do not descend into symlinks for ** unless following symlinks - #65435
Open
RafaelGSS wants to merge 1 commit into
Open
fs: do not descend into symlinks for ** unless following symlinks#65435RafaelGSS wants to merge 1 commit into
RafaelGSS wants to merge 1 commit into
Conversation
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
jasnell
approved these changes
Aug 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65435 +/- ##
==========================================
- Coverage 91.85% 90.12% -1.73%
==========================================
Files 400 752 +352
Lines 179110 252321 +73211
Branches 27351 47459 +20108
==========================================
+ Hits 164522 227414 +62892
- Misses 14258 16219 +1961
- Partials 330 8688 +8358
🚀 New features to boost your workflow:
|
MoLow
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs.glob(),fs.globSync(), andfs.promises.glob()descended into symlinked directories for globstar patterns even whenfollowSymlinkswasfalse. Restrict globstar recursion to directories so the default behavior and an explicitfalsevalue do not traverse symlink targets.