vfs: reject statfs for missing paths - #65693
Open
trivikr wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
fs
trivikr
added
the
request-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65693 +/- ##
==========================================
+ Coverage 90.16% 90.18% +0.01%
==========================================
Files 771 771
Lines 265094 265101 +7
Branches 50367 50366 -1
==========================================
+ Hits 239035 239083 +48
+ Misses 17000 16960 -40
+ Partials 9059 9058 -1
🚀 New features to boost your workflow:
|
trivikr
force-pushed
the
vfs-statfs-non-existent-paths
branch
from
September 2, 2026 00:07
859f592 to
40bd7ae
Compare
Validate mounted VFS paths before returning synthetic statfs data so fs.statfsSync() and fs.promises.statfs() report ENOENT for missing paths. Forward validation errors asynchronously to fs.statfs() callbacks. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
trivikr
force-pushed
the
vfs-statfs-non-existent-paths
branch
from
September 7, 2026 21:03
40bd7ae to
a58d860
Compare
jasnell
approved these changes
Sep 8, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
trivikr
added
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65692
Validate mounted VFS paths before returning synthetic statfs data so
fs.statfsSync()andfs.promises.statfs()reportENOENTfor missing paths. Forward validation errors asynchronously tofs.statfs()callbacks.Assisted-by: codex:gpt-5.6-sol