Skip to content

vfs: return FileHandle from fs.promises.open - #65730

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:vfs-promises-open-internals
Open

vfs: return FileHandle from fs.promises.open#65730
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:vfs-promises-open-internals

Conversation

@trivikr

@trivikr trivikr commented Sep 2, 2026

Copy link
Copy Markdown
Member

Fixes: #65729

Wrap mounted virtual file descriptors in the public FileHandle interface while delegating operations to the underlying provider handle.


Assisted-by: codex:gpt-5.6-sol

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem. labels Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.80488% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.16%. Comparing base (b4c83f5) to head (a94343b).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/vfs/fd.js 87.17% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65730      +/-   ##
==========================================
- Coverage   90.16%   90.16%   -0.01%     
==========================================
  Files         771      771              
  Lines      265094   265132      +38     
  Branches    50367    50365       -2     
==========================================
+ Hits       239035   239057      +22     
- Misses      17000    17015      +15     
- Partials     9059     9060       +1     
Files with missing lines Coverage Δ
lib/internal/vfs/setup.js 87.78% <100.00%> (-0.02%) ⬇️
lib/internal/vfs/fd.js 96.03% <87.17%> (-1.67%) ⬇️

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 2, 2026
Wrap mounted virtual file descriptors in the public FileHandle
interface while delegating operations to the underlying provider
handle.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
@trivikr
trivikr force-pushed the vfs-promises-open-internals branch from 576a7a4 to a94343b Compare September 7, 2026 21:04
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 8, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

@trivikr trivikr added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 8, 2026
@nodejs-github-bot nodejs-github-bot added the lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vfs: mounted fs.promises.open returns internal VFS handle instead of FileHandle

3 participants