Skip to content

tools: do not hardcode yamllint path - #65747

Open
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:yamllint-nix
Open

tools: do not hardcode yamllint path#65747
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:yamllint-nix

Conversation

@aduh95

@aduh95 aduh95 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Similar to #65681 for YAML linting.

Allows user to get `yamlllint` from other source than Pip (e.g. Nix).

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Sep 2, 2026
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Sep 2, 2026
@github-actions

This comment was marked as outdated.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor
Platform Number of requisites Proportion of new derivations
x86_64-linux 491 -> 496 => +5 5 / 496 = 1.0%
aarch64-linux 492 -> 497 => +5 5 / 497 = 1.0%
x86_64-darwin 428 -> 433 => +5 5 / 433 = 1.1%
aarch64-darwin 434 -> 439 => +5 5 / 439 = 1.1%
Total 1845 -> 1865 => +20 20 / 1865 = 1.0%
Changelog
@@ -853,0 +854,4 @@
+/nix/store/bjj2cb6caah2078q1bk4j8s7cvq95hzc-libyaml-0.2.5 (aarch64-darwin)
+/nix/store/i0nisf5slgb63g70cdpgpgiy555323dh-libyaml-0.2.5 (aarch64-linux)
+/nix/store/wdrrh2il7fnkin0c0n3jgdc32bihnph9-libyaml-0.2.5 (x86_64-darwin)
+/nix/store/r00l9hf8pvxc4yn3i624f99qyx3vsa9f-libyaml-0.2.5 (x86_64-linux)
@@ -1506,0 +1511,4 @@
+/nix/store/j715cvmzy32wy437621qvkcjfs5knp5c-python3.13-pathspec-1.0.4 (x86_64-darwin)
+/nix/store/4ki16hvm3d4zk4dpfi8qh1w8c8vvx5v4-python3.13-pyyaml-6.0.3 (x86_64-darwin)
+/nix/store/1mk6npxf8qlbpl5bpjd67xr31gls7adc-python3.13-yamllint-1.37.1 (x86_64-darwin)
+/nix/store/cjapzxdfwbk6x7sx24xjn3mxziqhl5fm-python3.13-yamllint-1.37.1-dist (x86_64-darwin)
@@ -1509,0 +1518,12 @@
+/nix/store/s27nwyhw59bc9n3lhlakn48pv6p50k67-python3.14-pathspec-1.1.1 (aarch64-darwin)
+/nix/store/kbgg1nfgl4wks2jdcm24g6bm7216hr8y-python3.14-pathspec-1.1.1 (aarch64-linux)
+/nix/store/p678v5a08jklyvvryz8s6g5n3pf90zs7-python3.14-pathspec-1.1.1 (x86_64-linux)
+/nix/store/dnfz9pyv9icrg3c8a8hpvxh5p0cw2k57-python3.14-pyyaml-6.0.3 (aarch64-darwin)
+/nix/store/hxjy4wxw60n3l3qan91b55fpb7p6dswg-python3.14-pyyaml-6.0.3 (aarch64-linux)
+/nix/store/xg127x7yvb0167539r0jswzg11hglxzb-python3.14-pyyaml-6.0.3 (x86_64-linux)
+/nix/store/f36awlm0ddvvvhb0sc17866fwqc22nzs-python3.14-yamllint-1.37.1 (aarch64-darwin)
+/nix/store/pf4f0ckn1kmlzys4xx02i0khr3piwby4-python3.14-yamllint-1.37.1 (aarch64-linux)
+/nix/store/jbhfmxfgpmnzf2b32i8cdiwlzir6nxw8-python3.14-yamllint-1.37.1 (x86_64-linux)
+/nix/store/irbfvpps45945xnwvx56gwhg9r415ziq-python3.14-yamllint-1.37.1-dist (aarch64-darwin)
+/nix/store/vwcv00y1sxx2v81cydsxx0jqk71y8jng-python3.14-yamllint-1.37.1-dist (aarch64-linux)
+/nix/store/734n3rgcg22kxg3vvjrsznh155y5nk3g-python3.14-yamllint-1.37.1-dist (x86_64-linux)

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.00%. Comparing base (5b912ed) to head (bab6fb5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65747      +/-   ##
==========================================
+ Coverage   89.98%   90.00%   +0.02%     
==========================================
  Files         757      757              
  Lines      257731   257731              
  Branches    48877    48876       -1     
==========================================
+ Hits       231918   231976      +58     
+ Misses      16893    16849      -44     
+ Partials     8920     8906      -14     

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants