test,benchmark: use OpenSSL feature helpers - #65762
Open
panva wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
addons
panva
force-pushed
the
crypto-openssl-feature-helpers
branch
from
September 3, 2026 13:28
b8c7948 to
eab15a4
Compare
richardlau
approved these changes
Sep 3, 2026
Add isBoringSSL to the test crypto helpers and use it in tests and benchmarks. Replace hasOpenSSL3 call sites with hasOpenSSL(3). Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
force-pushed
the
crypto-openssl-feature-helpers
branch
from
September 3, 2026 13:37
eab15a4 to
4df0bea
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65762 +/- ##
==========================================
- Coverage 89.96% 89.95% -0.01%
==========================================
Files 759 759
Lines 258637 258637
Branches 49007 49007
==========================================
- Hits 232673 232651 -22
- Misses 17016 17038 +22
Partials 8948 8948 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add isBoringSSL to the test crypto helpers and use it in tests and benchmarks. Replace hasOpenSSL3 call sites with hasOpenSSL(3).
I'm not removing the
hasOpenSSL3helper or blocking use ofprocess.features.openssl_is_boringsslwith a lint rule just yet, doing so would cause conflicts with other PRs that are in flight. I'll be on a lookout for a good opportunity to do so.