stream: optimize forEach(), some(), every() and find() functions on Readable - #65890
stream: optimize forEach(), some(), every() and find() functions on Readable#65890lukiano wants to merge 1 commit into
Conversation
…eadable
Signed-off-by: Luciano Leggieri <230980@gmail.com>
Assisted-by: Sol 5.6
|
Review requested:
|
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65890 +/- ##
========================================
Coverage 90.16% 90.17%
========================================
Files 771 771
Lines 265094 265299 +205
Branches 50367 50422 +55
========================================
+ Hits 239035 239234 +199
- Misses 17000 17015 +15
+ Partials 9059 9050 -9
🚀 New features to boost your workflow:
|
|
See Commit message guidelines according to the Pull requests documentation. Your commit must contain the |
I'm splitting my previous PR into smaller chunks, hoping the changes are easier to understand.
This one modifies the following iterator helpers:
forEach()some()every()find()Please see my previous PR that contains screenshots of benchmarks showcasing the performance improvements in this proposal.
Note that
someandeveryused to depend onfilterbut they now depend onfind.In terms of the logic inside
operators.js, it's not easy to view these changes as a diff because the previous logic almost entirely relied oncreateAsyncIterator, which is in a different file (readable.js) and the asynchronous iteration engine that v8 provides. The new proposal is an implementation from scratch that keeps the same compatibility evaluated by the tests, but with improved performance. It's better to consider both as black box implementations rather than trying to diff.