Skip to content

Revert "inspector: defer JS execution from V8 interrupts" - #65907

Open
aduh95 wants to merge 3 commits into
nodejs:mainfrom
aduh95:revert-65397
Open

Revert "inspector: defer JS execution from V8 interrupts"#65907
aduh95 wants to merge 3 commits into
nodejs:mainfrom
aduh95:revert-65397

Conversation

@aduh95

@aduh95 aduh95 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/inspector
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 8, 2026
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 8, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 8, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 45.71429% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (70458d5) to head (f4ae6b8).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
src/inspector_agent.cc 42.18% 22 Missing and 15 partials ⚠️
src/inspector_js_api.cc 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65907      +/-   ##
==========================================
- Coverage   90.18%   90.17%   -0.01%     
==========================================
  Files         771      771              
  Lines      265103   265078      -25     
  Branches    50353    50368      +15     
==========================================
- Hits       239082   239037      -45     
- Misses      16968    16991      +23     
+ Partials     9053     9050       -3     
Files with missing lines Coverage Δ
src/inspector_agent.h 100.00% <ø> (ø)
src/inspector_js_api.cc 77.01% <83.33%> (-7.08%) ⬇️
src/inspector_agent.cc 81.13% <42.18%> (-0.37%) ⬇️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller

Copy link
Copy Markdown
Member

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. fast-track PRs proposed for a shorter-than-standard waiting period before landing. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants