Skip to content

fs: stat src through symlinks in cpSync() when dereference is set - #67340

Open
yohannesjoya wants to merge 1 commit into
nodejs:mainfrom
yohannesjoya:fs-cpsync-dereference-src
Open

yohannesjoya wants to merge 1 commit into
nodejs:mainfrom
yohannesjoya:fs-cpsync-dereference-src

Conversation

@yohannesjoya

Copy link
Copy Markdown
Contributor

cpSync() checked src with symlink_status() when dereference was true and with status() when it was false, the reverse of what the option means. #59681 fixed the same swap for dest but left src as it was. So a symlink to a file passed as src with dereference: true was treated as a directory: cpSync() threw ERR_FS_EISDIR unless recursive was set, while fs.cp() copied the file.

This swaps the two calls and drops the check that counted a symlink as a directory, which status() can no longer return. The new test covers both cpSync() and fs.cp() and fails on main.

This is @npaun's fix from #60945, which the stale bot closed. I asked there on Oct 31 whether they planned to reopen it and got no reply, so I've rebased it and added the test, with them as co-author.

Refs: #59168

AI disclosure: I used an AI assistant to help find, test and write up this change. I reviewed and tested it myself.

CpSyncCheckPaths() used symlink_status() for src when dereference was
true and status() when it was false, the reverse of what the option
means. nodejs#59681 fixed the same swap for dest but left src as it was.
A symlink to a file passed as src with dereference: true was treated
as a directory, so cpSync() threw ERR_FS_EISDIR unless recursive was
set, while fs.cp() copied the file.

Swap the two calls and drop the check that counted a symlink as a
directory, which status() can no longer return.

Refs: nodejs#59168
Refs: nodejs#60945
Co-authored-by: Nicholas Paun <npaun@cloudflare.com>
Signed-off-by: yohannesjoya <yohannesdestagebru10@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

@yohannesjoya

Copy link
Copy Markdown
Contributor Author

@LiviaMedeiros this ports the fix from #60945, which you reviewed, plus the async test you asked for there. Could you take a look and start CI?

@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 15, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 16, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Comment on lines +37 to +38
cp(join(src, 'link.txt'), dest, opts, mustCall((err) => {
assert.ifError(err);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit (i think this was supposed to be catchable by lint rule?):

Suggested change
cp(join(src, 'link.txt'), dest, opts, mustCall((err) => {
assert.ifError(err);
cp(join(src, 'link.txt'), dest, opts, mustSucceed(() => {

@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.68%. Comparing base (c99ebf2) to head (5c9f6d9).
⚠️ Report is 163 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67340      +/-   ##
==========================================
- Coverage   92.99%   90.68%   -2.32%     
==========================================
  Files         428      797     +369     
  Lines      195633   279572   +83939     
  Branches    30281    53773   +23492     
==========================================
+ Hits       181937   253521   +71584     
- Misses      13369    16342    +2973     
- Partials      327     9709    +9382     
Files with missing lines Coverage Δ
src/node_file.cc 76.12% <100.00%> (ø)

... and 509 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants