Repository navigation
Conversation
The PSK server returned the secret for any identity. The client also offers its resumption ticket as a PSK identity, and OpenSSL passes it to pskCallback when its leading bytes read as a string, for example when the random ticket key name starts with a NUL byte. The server then used the ticket as an external PSK with the wrong key and failed the binder check with decrypt_error, in about 0.7% of runs. Only return the secret for the identity the client uses. Refs: https://github.com/nodejs/node/actions/runs/43411330264/job/131838200960 Signed-off-by: Matteo Collina <hello@matteocollina.com>
Member
|
This is already fixed by #67450 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67458 +/- ##
==========================================
+ Coverage 90.70% 90.71% +0.01%
==========================================
Files 802 802
Lines 282109 282109
Branches 54364 54356 -8
==========================================
+ Hits 255881 255923 +42
+ Misses 16359 16318 -41
+ Partials 9869 9868 -1 🚀 New features to boost your workflow:
|
jasnell
approved these changes
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PSK server in this test returned the secret for any identity. The client also offers its resumption ticket as a PSK identity, and OpenSSL passes it to
pskCallbackwhen its leading bytes read as a string, for example''when the random ticket key name starts with a NUL byte. The server then took the ticket as an external PSK with the wrong key, and the handshake failed the binder check withdecrypt_error.This happened in about 0.7% of runs locally (7/1000) and showed up in CI on #67271 (job). With the fix, the server only answers for the
'client'identity, and 1000 runs passed. Forcing a ticket key name that starts with a NUL byte fails every time before the fix and passes after it.