Skip to content

build: use Highway EMU128 on riscv64 - #67459

Open
AFOliveira wants to merge 1 commit into
nodejs:mainfrom
AFOliveira:riscv/node-highway
Open

AFOliveira wants to merge 1 commit into
nodejs:mainfrom
AFOliveira:riscv/node-highway

Conversation

@AFOliveira

Copy link
Copy Markdown

rv64gc has no SIMD baseline. With GCC before 16, Highway then falls back to HWY_SCALAR, where V8's json-stringifier.cc does not compile. This selects EMU128 on riscv64, as is already done for armv7.

Node.js builds and runs its test suite on riscv64 with this change.

AI assistance: Claude was used for this change.

rv64gc has no SIMD baseline. With GCC before 16, Highway then falls
back to HWY_SCALAR, where V8's json-stringifier.cc does not compile.
Select EMU128 on riscv64, as is already done for armv7.

Node.js builds and runs its test suite on riscv64 with this change.

Assisted-by: Claude
Signed-off-by: Afonso Oliveira <aoliveira@velaura.ai>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Nov 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

Caution

AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context.

@AFOliveira

Copy link
Copy Markdown
Author

Caution

AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context.

This was tested by me - I'm Afonso, a human :)

@Renegade334

Copy link
Copy Markdown
Member

cc @nodejs/platform-riscv64

@Renegade334 Renegade334 added the riscv64 Issues and PRs related to the 64-bit RISC-V architecture. label Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentscan:automated-account needs-ci PRs that need a full CI run. riscv64 Issues and PRs related to the 64-bit RISC-V architecture. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants