Repository navigation
build: use Highway EMU128 on riscv64 - #67459
AFOliveira wants to merge 1 commit into
Conversation
rv64gc has no SIMD baseline. With GCC before 16, Highway then falls back to HWY_SCALAR, where V8's json-stringifier.cc does not compile. Select EMU128 on riscv64, as is already done for armv7. Node.js builds and runs its test suite on riscv64 with this change. Assisted-by: Claude Signed-off-by: Afonso Oliveira <aoliveira@velaura.ai>
|
Review requested:
|
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. Caution AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context. |
This was tested by me - I'm Afonso, a human :) |
|
cc @nodejs/platform-riscv64 |
rv64gc has no SIMD baseline. With GCC before 16, Highway then falls back to
HWY_SCALAR, where V8'sjson-stringifier.ccdoes not compile. This selects EMU128 on riscv64, as is already done for armv7.Node.js builds and runs its test suite on riscv64 with this change.
AI assistance: Claude was used for this change.