Skip to content

doc,test: deprecate util.TextDecoder and util.TextEncoder - #67461

Closed
LiviaMedeiros wants to merge 4 commits into
nodejs:mainfrom
LiviaMedeiros:util-deprecate-textcoder
Closed

LiviaMedeiros wants to merge 4 commits into
nodejs:mainfrom
LiviaMedeiros:util-deprecate-textcoder

Conversation

@LiviaMedeiros

Copy link
Copy Markdown
Member

util.TextDecoder === globalThis.TextDecoder && util.TextEncoder === globalThis.TextEncoder.

The globals were added back in v11.0, more than 8 years ago. There is no reason to prefer node:util versions in userland, it only adds unnecessary import and reduces compatibility. Also nowadays we have TextDecoderStream and TextEncoderStream that aren't mirrored.
I think we should discourage node:util versions and possibly remove them at some point.

@LiviaMedeiros LiviaMedeiros added deprecations Issues and PRs related to deprecations. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Nov 13, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 13, 2026
@LiviaMedeiros
LiviaMedeiros force-pushed the util-deprecate-textcoder branch from 299944b to 2799562 Compare November 13, 2026 23:58
@LiviaMedeiros LiviaMedeiros added doc Issues and PRs related to Node.js documentation. test Issues and PRs related to Node.js core tests and test infrastructure. util Issues and PRs related to the built-in util module. labels Nov 13, 2026
@LiviaMedeiros
LiviaMedeiros force-pushed the util-deprecate-textcoder branch from 2799562 to b3e0814 Compare November 14, 2026 00:06
@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (b0aa887) to head (b2df4d7).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67461      +/-   ##
==========================================
- Coverage   90.66%   90.66%   -0.01%     
==========================================
  Files         799      799              
  Lines      280245   280245              
  Branches    54115    54112       -3     
==========================================
- Hits       254093   254091       -2     
- Misses      16276    16282       +6     
+ Partials     9876     9872       -4     

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread doc/api/deprecations.md Resolved

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if stability Legacy would not be more appropriate, given that maintenance burden for this alias is virtually null, so it wouldn't really make sense to break it for the ecosystem. I guess we can always start with doc-deprecation, IMO runtime deprecation would only make sense if we cannot detect ecosystem use.

Comment thread doc/api/util.md Resolved
@Renegade334

Renegade334 commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Is this a practice we want to commit to? TextEncoder is far from unique in this regard (require('http').WebSocket, require('stream/web') etc.)

@LiviaMedeiros

Copy link
Copy Markdown
Member Author

I wonder if stability Legacy would not be more appropriate, given that maintenance burden for this alias is virtually null, so it wouldn't really make sense to break it for the ecosystem. I guess we can always start with doc-deprecation, IMO runtime deprecation would only make sense if we cannot detect ecosystem use.

Yep, fully agreed.

Is this a practice we want to commit to? TextEncoder is far from unique in this regard (require('http').WebSocket, require('stream/web') etc.)

It should be weighted individually for each global (for example, some might be easier/harder to runtime deprecate, in case of node:timers i would actually prefer if we made timers.setTimeout !== globalThis.setTimeout); but in general, if it's just a legacy Node.js-specific alias, it should be discouraged as well.
TextEncoder is most outstanding one because it sits in generic node:util module, and is misaligned with TextEncoderStream.

@panva panva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LiviaMedeiros
LiviaMedeiros force-pushed the util-deprecate-textcoder branch from b3e0814 to c127f2e Compare November 14, 2026 21:14
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

Signed-off-by: LiviaMedeiros <livia@cirno.name>
…:util`

Signed-off-by: LiviaMedeiros <livia@cirno.name>
Signed-off-by: LiviaMedeiros <livia@cirno.name>
Signed-off-by: LiviaMedeiros <livia@cirno.name>
@LiviaMedeiros
LiviaMedeiros force-pushed the util-deprecate-textcoder branch from c127f2e to b2df4d7 Compare November 15, 2026 13:49
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@LiviaMedeiros LiviaMedeiros added notable-change PRs with changes that should be highlighted in changelogs. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Nov 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @LiviaMedeiros.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@gurgunday gurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LiviaMedeiros

Copy link
Copy Markdown
Member Author
Tried to roughly weight the other globals that have references within builtin modules.
atob:
  - '{buffer}.atob'
Blob:
  - '{buffer}.Blob'
BroadcastChannel:
  - '{worker_threads}.BroadcastChannel'
btoa:
  - '{buffer}.btoa'
Buffer:
  - '{buffer}.Buffer'
ByteLengthQueuingStrategy:
  - '{stream/web}.ByteLengthQueuingStrategy'
clearImmediate:
  - '{timers}.clearImmediate'
clearInterval:
  - '{timers}.clearInterval'
clearTimeout:
  - '{timers}.clearTimeout'
CloseEvent:
  - '{http}.CloseEvent'
CompressionStream:
  - '{stream/web}.CompressionStream'
CountQueuingStrategy:
  - '{stream/web}.CountQueuingStrategy'
crypto:
  - '{crypto}.webcrypto'
DecompressionStream:
  - '{stream/web}.DecompressionStream'
Error:
  - '{v8}.Serializer.prototype._getDataCloneError'
File:
  - '{buffer}.File'
MessageChannel:
  - '{worker_threads}.MessageChannel'
MessageEvent:
  - '{http}.MessageEvent'
MessagePort:
  - '{worker_threads}.MessagePort'
performance:
  - '{perf_hooks}.performance'
Performance:
  - '{perf_hooks}.Performance'
PerformanceEntry:
  - '{perf_hooks}.PerformanceEntry'
PerformanceMark:
  - '{perf_hooks}.PerformanceMark'
PerformanceMeasure:
  - '{perf_hooks}.PerformanceMeasure'
PerformanceObserver:
  - '{perf_hooks}.PerformanceObserver'
PerformanceObserverEntryList:
  - '{perf_hooks}.PerformanceObserverEntryList'
PerformanceResourceTiming:
  - '{perf_hooks}.PerformanceResourceTiming'
ReadableByteStreamController:
  - '{stream/web}.ReadableByteStreamController'
ReadableStream:
  - '{stream/web}.ReadableStream'
ReadableStreamBYOBReader:
  - '{stream/web}.ReadableStreamBYOBReader'
ReadableStreamBYOBRequest:
  - '{stream/web}.ReadableStreamBYOBRequest'
ReadableStreamDefaultController:
  - '{stream/web}.ReadableStreamDefaultController'
ReadableStreamDefaultReader:
  - '{stream/web}.ReadableStreamDefaultReader'
setImmediate:
  - '{timers}.setImmediate'
setInterval:
  - '{timers}.setInterval'
setTimeout:
  - '{timers}.setTimeout'
TextDecoder:
  - '{sys}.TextDecoder'
  - '{util}.TextDecoder'
TextDecoderStream:
  - '{stream/web}.TextDecoderStream'
TextEncoder:
  - '{sys}.TextEncoder'
  - '{util}.TextEncoder'
TextEncoderStream:
  - '{stream/web}.TextEncoderStream'
TransformStream:
  - '{stream/web}.TransformStream'
TransformStreamDefaultController:
  - '{stream/web}.TransformStreamDefaultController'
URL:
  - '{url}.URL'
URLPattern:
  - '{url}.URLPattern'
URLSearchParams:
  - '{url}.URLSearchParams'
WebSocket:
  - '{http}.WebSocket'
WritableStream:
  - '{stream/web}.WritableStream'
WritableStreamDefaultController:
  - '{stream/web}.WritableStreamDefaultController'
WritableStreamDefaultWriter:
  - '{stream/web}.WritableStreamDefaultWriter'

In the docs, most of the time code examples have them imported only in their own modules where it makes sense.

In my personal opinion...

  • node:buffer:
    • It's a questionable place for Blob and File. It also has Node.js-specific resolveObjectURL().
    • Buffer itself is opposite to this: it would make more sense to mark global as legacy, but i don't see it moving anywhere anytime soon.
    • atob and btoa... Fast and Deprecated™️, nothing to say about it.
  • node:timers:
    • I'm in favour of breakings change separating this module's implementation and global web-compatible one. It's in terrible state, we can't move backward because it breaks compatibility, we can't move forward because it breaks compatibility, we can't keep it as is because the compatibility is already broken. One of actionable ways forward could be:
      1. Introduce brand new node:timers_ng (name TBD) that is not bound to web spec
      2. Similarly to this PR, deprecate node:timers aliases and whole node:timers module, in favour of globals or ng module, userland chooses for themselves
      3. (semver-major) maybe make globals more webspec-compatible
      4. (semver-major) maybe eventually remove node:timers module
  • node:http:
    • According to http: expose websocket in nodehttp #53721, WebSocket is here so it could be backported to v20.x which is EOL. It also added exports for CloseEvent and MessageEvent which are still undocumented. Looks runtime-deprecatable to me.
  • node:crypto:
    • webcrypto feel borderline, it's like this for legacy reasons and probably can't be helped.
  • everything else:
    • not questionable as it's sensibly namespaced.

Namespaced references IMHO are fine to keep as is, at least because they offload the volume of documentation from globals.
Other than that, i think the rule of thumb should be soft-discourage by not having them referenced outside of their namespaces. E.g. it should be fine to import URL from node:url in docs and tests for node:url itself, but we should stick to the global class in http or any other doc.

@LiviaMedeiros LiviaMedeiros added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 15, 2026
@jasnell

jasnell commented Nov 15, 2026

Copy link
Copy Markdown
Member

I think we do eventually want everything that is expected to be a global exposed as such but adding globals is always semver-major. That makes it extremely difficult to introduce the APIs in a way that we know they can be used and tested. Adding them as exports on an existing module first allows it to be semver-minor. I think we want to keep that but we need to be able to have a reasonable transition path to global-ness. For now, let's get this one landed and we'll handle the others as case-by-case.

@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 16, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

     ⚠  0:50     Title should be <= 50 columns.            title-length
  ✖  984b4c66c98ee27dca3426651e8cc88496835791
     ✖  0:72     Title must be <= 72 columns.              title-length
     ⚠  0:50     Title should be <= 50 columns.            title-length
     ⚠  0:50     Title should be <= 50 columns.            title-length

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
�[36m⠋�[39m Loading data for nodejs/node/pull/67461
�[36m⠋�[39m Loading data for nodejs/node/pull/67461
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/67461
�[36m⠋�[39m Getting reviews from nodejs/node/pull/67461
�[36m⠋�[39m Getting comments from nodejs/node/pull/67461
�[36m⠋�[39m Getting commits from nodejs/node/pull/67461
✔  Done loading data for nodejs/node/pull/67461
----------------------------------- PR info ------------------------------------
Title      doc,test: deprecate `util.TextDecoder` and `util.TextEncoder` (#67461)
Author     Livia Medeiros <livia@cirno.name> (@LiviaMedeiros)
Branch     LiviaMedeiros:util-deprecate-textcoder -> nodejs:main
Labels     util, doc, test, notable-change, encoding, author ready, deprecations, needs-ci, commit-queue, commit-queue-rebase
Commits    4
 - doc: deprecate `util.TextDecoder` and `util.TextEncoder`
 - doc: refer to global `TextDecoder` and `TextEncoder` instead of `node…
 - doc: swap `util.TextDecoder` and `util.TextEncoder` with globals
 - test: remove unnecessary imports for `TextDecoder` and `TextEncoder`
Committers 1
 - LiviaMedeiros <livia@cirno.name>
PR-URL: https://github.com/nodejs/node/pull/67461
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/67461
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 13 Nov 2026 23:55:39 GMT
   ✔  Approvals: 5
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/67461#pullrequestreview-5900280696
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/67461#pullrequestreview-5901005583
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/67461#pullrequestreview-5904667709
   ✔  - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/67461#pullrequestreview-5906208842
   ✔  - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/67461#pullrequestreview-5913094512
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-11-15T16:01:31Z: https://ci.nodejs.org/job/node-test-pull-request/79121/
�[36m⠙�[39m Querying data for job/node-test-pull-request/79121/
�[36m⠙�[39m Querying data for job/node-test-pull-request/79121/
�[36m⠙�[39m Querying API for job/node-test-pull-request/79121/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
�[36m⠹�[39m Bringing origin/main up to date...
�[36m⠹�[39m Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
�[36m⠸�[39m Downloading patch for 67461
�[36m⠸�[39m Downloading patch for 67461
From https://github.com/nodejs/node
 * branch                  refs/pull/67461/merge -> FETCH_HEAD
✔  Fetched commits as b0aa8874128b..b2df4d75fc9c
--------------------------------------------------------------------------------
[main 55d0565f3b] doc: deprecate `util.TextDecoder` and `util.TextEncoder`
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Sat Nov 14 07:02:31 2026 +0800
 3 files changed, 17 insertions(+), 1 deletion(-)
[main bffb44ac68] doc: refer to global `TextDecoder` and `TextEncoder` instead of `node:util`
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Sat Nov 14 07:10:26 2026 +0800
 3 files changed, 5 insertions(+), 7 deletions(-)
[main 34ac1b412b] doc: swap `util.TextDecoder` and `util.TextEncoder` with globals
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Sat Nov 14 07:28:46 2026 +0800
 2 files changed, 178 insertions(+), 178 deletions(-)
[main 020e3dcae7] test: remove unnecessary imports for `TextDecoder` and `TextEncoder`
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Sat Nov 14 07:40:41 2026 +0800
 3 files changed, 3 deletions(-)
   ✔  Patches applied
There are 4 commits in the PR. Attempting autorebase.
(node:412) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/8)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: deprecate `util.TextDecoder` and `util.TextEncoder`

Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: https://github.com/nodejs/node/pull/67461
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
[detached HEAD 84a33acdd8] doc: deprecate `util.TextDecoder` and `util.TextEncoder`
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Sat Nov 14 07:02:31 2026 +0800
 3 files changed, 17 insertions(+), 1 deletion(-)
Rebasing (3/8)
Rebasing (4/8)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: refer to global `TextDecoder` and `TextEncoder` instead of `node:util`

Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: https://github.com/nodejs/node/pull/67461
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
[detached HEAD 984b4c66c9] doc: refer to global `TextDecoder` and `TextEncoder` instead of `node:util`
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Sat Nov 14 07:10:26 2026 +0800
 3 files changed, 5 insertions(+), 7 deletions(-)
Rebasing (5/8)
Rebasing (6/8)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: swap `util.TextDecoder` and `util.TextEncoder` with globals

Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: https://github.com/nodejs/node/pull/67461
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
[detached HEAD a41a70aa4b] doc: swap `util.TextDecoder` and `util.TextEncoder` with globals
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Sat Nov 14 07:28:46 2026 +0800
 2 files changed, 178 insertions(+), 178 deletions(-)
Rebasing (7/8)
Rebasing (8/8)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: remove unnecessary imports for `TextDecoder` and `TextEncoder`

Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: https://github.com/nodejs/node/pull/67461
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
--------------------------------------------------------------------------------
[detached HEAD 35de1fc6b8] test: remove unnecessary imports for `TextDecoder` and `TextEncoder`
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Sat Nov 14 07:40:41 2026 +0800
 3 files changed, 3 deletions(-)
Successfully rebased and updated refs/heads/main.
--------------------------------------------------------------------------------
  ✔  84a33acdd858d2ff9d9b03b65c6faca2211a3854
     ✔  0:0      no Assisted-by metadata                   assisted-by-is-trailer
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  2:8      PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✔  0:0      has valid Signed-off-by                   signed-off-by
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ⚠  0:50     Title should be <= 50 columns.            title-length
  ✖  984b4c66c98ee27dca3426651e8cc88496835791
     ✔  0:0      no Assisted-by metadata                   assisted-by-is-trailer
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  2:8      PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✔  0:0      has valid Signed-off-by                   signed-off-by
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ✖  0:72     Title must be <= 72 columns.              title-length
  ✔  a41a70aa4b317b883fb387c3c8bec6c451deef67
     ✔  0:0      no Assisted-by metadata                   assisted-by-is-trailer
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  2:8      PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✔  0:0      has valid Signed-off-by                   signed-off-by
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ⚠  0:50     Title should be <= 50 columns.            title-length
  ✔  35de1fc6b872af376516c18ba827226f6c264001
     ✔  0:0      no Assisted-by metadata                   assisted-by-is-trailer
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  2:8      PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✔  0:0      has valid Signed-off-by                   signed-off-by
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ⚠  0:50     Title should be <= 50 columns.            title-length
--------------------------------------------------------------------------------
   ℹ  Please fix the commit message and try again.
Please manually ammend the commit message, by running
`git commit --amend`
Once commit message is fixed, finish the landing command running
`git node land --continue`

View workflow run

@LiviaMedeiros LiviaMedeiros self-assigned this Nov 16, 2026
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Nov 16, 2026
Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: nodejs#67461
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Nov 16, 2026
Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: nodejs#67461
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Nov 16, 2026
Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: nodejs#67461
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Nov 16, 2026
Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: nodejs#67461
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Nov 16, 2026
Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: nodejs#67461
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Nov 16, 2026
Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: nodejs#67461
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Nov 16, 2026
Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: nodejs#67461
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Nov 16, 2026
Signed-off-by: LiviaMedeiros <livia@cirno.name>
PR-URL: nodejs#67461
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@LiviaMedeiros

Copy link
Copy Markdown
Member Author

Landed in 8dbdd03...ab476ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to Node.js documentation. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. test Issues and PRs related to Node.js core tests and test infrastructure. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants