Repository navigation
Conversation
Package "exports" subpaths ending in "/" now throw ERR_INVALID_MODULE_SPECIFIER instead of emitting DEP0155, matching the existing "imports" behavior and the documented resolution algorithm. "imports" and "exports" targets containing empty segments (double, leading, or trailing slashes after the initial "./") now throw ERR_INVALID_PACKAGE_TARGET, and pattern matches containing empty segments now throw ERR_INVALID_MODULE_SPECIFIER, instead of emitting DEP0166. The isPathMap parameter, which only served to suppress DEP0166 for trailing slash pattern resolutions, is removed. DEP0155 has been a runtime deprecation since v17.0.0, DEP0166 since v19.0.0. Refs: nodejs#40117 Refs: nodejs#44495 Assisted-by: Claude Signed-off-by: James M Snell <jasnell@gmail.com>
Collaborator
|
Review requested:
|
jasnell
commented
Nov 15, 2026
jasnell
commented
Nov 15, 2026
Co-authored-by: James M Snell <jasnell@gmail.com>
panva
approved these changes
Nov 15, 2026
This comment was marked as outdated.
This comment was marked as outdated.
GeoffreyBooth
approved these changes
Nov 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67488 +/- ##
=======================================
Coverage 90.67% 90.67%
=======================================
Files 799 799
Lines 280245 280159 -86
Branches 54125 54099 -26
=======================================
- Hits 254100 254042 -58
+ Misses 16280 16242 -38
- Partials 9865 9875 +10
🚀 New features to boost your workflow:
|
Collaborator
Member
Author
|
@nodejs/tsc ... will need another sign off here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package "exports" subpaths ending in "/" now throw ERR_INVALID_MODULE_SPECIFIER instead of emitting DEP0155, matching the existing "imports" behavior and the documented resolution algorithm.
"imports" and "exports" targets containing empty segments (double, leading, or trailing slashes after the initial "./") now throw ERR_INVALID_PACKAGE_TARGET, and pattern matches containing empty segments now throw ERR_INVALID_MODULE_SPECIFIER, instead of emitting DEP0166.
The isPathMap parameter, which only served to suppress DEP0166 for trailing slash pattern resolutions, is removed.
DEP0155 has been a runtime deprecation since v17.0.0, DEP0166 since v19.0.0.
Refs: #40117
Refs: #44495